Opened 23 months ago

Closed 23 months ago

Last modified 22 months ago

#13152 closed Bug Report - General (fixed)

ttvdb.py fails for a series with no episodes listed in ttvdb

Reported by: Peter Bennett Owned by: Mark Spieth
Priority: minor Milestone: 29.1
Component: MythTV - Mythmetadatalookup Version: v29.0
Severity: medium Keywords:
Cc: Ian, Evans, <dheianevans@…> Ticket locked: no

Description

This used to work before, meta data could get artwork even if it could not get episode info. See email link below.

/usr/share/mythtv/metadata/Television/ttvdb.py -l en -a CA -C 334660
! Error: 'NoneType' object is not iterable
Traceback (most recent call last):
  File "/home/peter/proj/build/xenial-amd64/mythtv/master-tst/usr/share/mythtv/metadata/Television/ttvdb.py", line 2464, in <module>
    sys.exit(main())
  File "/home/peter/proj/build/xenial-amd64/mythtv/master-tst/usr/share/mythtv/metadata/Television/ttvdb.py", line 2257, in main
    t._getShowData(series_season_ep[0], opts.language)
  File "/home/peter/proj/build/xenial-amd64/mythtv/master-tst/usr/local/lib/python2.7/dist-packages/MythTV/ttvdb/tvdb_api.py", line 1079, in _getShowData
    for cur_ep in epsEt:
TypeError: 'NoneType' object is not iterable

http://lists.mythtv.org/pipermail/mythtv-users/2017-October/393379.html

Change History (6)

comment:1 Changed 23 months ago by Mark Spieth <mspieth@…>

Resolution: fixed
Status: newclosed

In 2dda8727d6381540a486a75d7547b8bbeca1bb4a/mythtv:

ttvdb: Check if episodes are received before parsing them. Fixes #13152

comment:2 Changed 22 months ago by Peter Bennett

I recommend cherry-pick this into fixes/29 and fixes/0.28 if you are happy with it. Those both have the new ttvdb.py code.

comment:3 Changed 22 months ago by Mark Spieth

Agree. Ill try to get it done tonight unless you do it first.

It could be improved with a test but I was lazy when I did it.

comment:4 Changed 22 months ago by Mark Spieth <mspieth@…>

In 43188b7fe1bbd5c6f9e9810b5123be8db251cedf/mythtv:

ttvdb: Check if episodes are received before parsing them. Fixes #13152

(cherry picked from commit 2dda8727d6381540a486a75d7547b8bbeca1bb4a)

comment:5 Changed 22 months ago by Mark Spieth <mspieth@…>

In 760bcea4f0ae7499d16b2a614afff5852ded758f/mythtv:

ttvdb: Check if episodes are received before parsing them. Fixes #13152

(cherry picked from commit 2dda8727d6381540a486a75d7547b8bbeca1bb4a)

comment:6 Changed 22 months ago by Stuart Auchterlonie

Milestone: needs_triage29.1
Version: Master Headv29.0
Note: See TracTickets for help on using tickets.