Errors in new setup screens for VBOX tuners

[Peter Bennett]

While fixing the HD Homerun setup screens I noticed that some of the same issues may exist in the VBOX setup screen. See #13139.

I do not have a VBOX tuner to test with so I cannot verify if these problems all exist.

• When an existing capture card is selected, Available devices shows "Manually enter". It should show the selected id.
• When an existing capture card is selected the currently selected shows "warning already in use". It should only show that if it is in use on another tuner.
• Device id must always be read-only. currently it is always updateable.
• When "manually enter ip address" is selected, IP address and tuner should be updateable. They are not.
• When updating ip address or tuner, the device id should be changed to match what is entered.
• When editing an existing tuner, the tuner id shows as 0. It should show the correct value.

[mike.bibbings@…]

Peter, I have a couple of Vboxes and can confirm the issues you have identified in fixes/29 and master. fixes/0.28 is OK.

The Device ID as you state should be readonly to the user, but gets automatically updated by either the user selecting one of the automatically detected (upnp) Tuners or by the user using manual and inputting ip address and Tuner (including Type).

I don't normally use the manual ip address and Tuner items as I believe this is only necessary on systems/networks with "broken" upnp, you are correct they should only be updateable when using manual, any changes to ip address and or Tuner should be reflected in the Device ID.

In the case of manual the Description field should be blank, it should only get populated when one of the auto (upnp) detected tuners is selected.

I can test any patch you may have on either fixes/29 or master.

Mike

[Peter Bennett]

VBOX setup fixes

[Peter Bennett]

Please test the attached patch for VBox setup. It is applicable to master and fixes/29.

[mike.bibbings@…]

Peter,

Patch tested on current fixes/29 and master on Xubuntu 16.04 LTS, works fine.

Mike

[Peter Bennett <pbennett@…>]

In e601de058ae428cee771dc8e92a2220851f03b19/mythtv:

Setup: New Setup - fix multiple issues with VBox tuners

Fixes the same issues as existed with HDHomerun Prime tuners
See commit 7294644

Fixes #13165

[Peter Bennett <pbennett@…>]

In eea89c909396c9c58b1638ff25273e877b5dbbab/mythtv:

Setup: New Setup - fix multiple issues with VBox tuners

Fixes the same issues as existed with HDHomerun Prime tuners
See commit 7294644

Fixes #13165

(cherry picked from commit e601de058ae428cee771dc8e92a2220851f03b19)