Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#13259 closed Developer Task (fixed)

Decouple MythTV configure from FFmpeg configure

Reported by: Peter Bennett Owned by: Peter Bennett
Priority: minor Milestone: 30.0
Component: MythTV - configure script Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

The process of syncing new versions of FFmpeg into MythTV is very cumbersome:

  1. Take a new FFmpeg branch and apply all of our customizations to it
  1. Take the configure script from the new FFmpeg branch and apply all changes since the last FFmpeg sync to our MythTV configure.

Step 2 takes most of the time and is anything but straightforward.

I will update MythTV configure to eliminate step 2 and make the MythTV configure invoke the FFmpeg configure as part of its run.

Change History (16)

comment:1 Changed 2 years ago by Peter Bennett <pbennett@…>

In 8a9451506812871b4c543c4b09b219f0e137a4d3/mythtv:

Decouple MythTV configure from FFmpeg configure, first step

Instead of having MythTV configure do all the work that is needed for
FFmpeg, rather have MythTV configure invoke the FFmpeg configure.
This eliminates the need to keep updating MythTV configure with FFmpeg
changes.

This is step 1. FFmpeg configure is invoked and MythTV configure does
none of the FFmpeg work. There is still much unneeded FFmpeg
code in the MythTV configure.

Refs #13259

comment:2 Changed 2 years ago by warpme@…

Peter, FYI Excellent work! Compiles no single issue and works OK under cross-compile environment of minimyth2.

comment:3 Changed 2 years ago by Peter Bennett <pbennett@…>

In 1ac3f7d7d4e06889b857966d74f3bb0f62ef18f5/mythtv:

Decouple MythTV configure from FFmpeg configure, additional changes

Remove some unneeded code from configure and fix some errors in the
FFmpeg configure parameters.

Refs #13259

comment:4 Changed 2 years ago by Peter Bennett <pbennett@…>

In ca41f665f46b1fd82070deafb8e31cb1385e695b/mythtv:

Decouple MythTV configure from FFmpeg configure, additional changes

Remove more unneeded code from configure.

Refs #13259

comment:5 Changed 2 years ago by Peter Bennett

Owner: changed from Peter Bennett to Peter Bennett
Status: newassigned

comment:6 Changed 2 years ago by Peter Bennett <pbennett@…>

In 66a001b743/mythtv:

Decouple MythTV configure from FFmpeg configure, additional changes

Remove more unneeded code from configure.

Refs #13259

comment:7 Changed 2 years ago by Peter Bennett

At this point, MythTV configure has been reduced from 9325 lines to 7721 lines. I have been removing settings one at a time from the configure after scanning MythTV source to ensure they are not used. Continuing to do it this way will take a very long time. I do not want to remove large sections without checking that they are not used. At this point I am going to stop the clean up. MythTV configure no longer needs to be merged with FFmpeg configure when upgrading FFmpeg, which was the main driver of this effort. Further cleanup would be better done by putting together what is absolutely needed rather than by trying to pull out stuff that is unneeded.

comment:8 Changed 2 years ago by Peter Bennett <pbennett@…>

In d333a549c/mythtv:

Decouple MythTV configure from FFmpeg configure, additional changes

Small fix for android configure that was failing with prior changes.

Refs #13259

comment:9 Changed 2 years ago by Peter Bennett <pbennett@…>

Resolution: fixed
Status: assignedclosed

In 9563786648/mythtv:

Decouple MythTV configure from FFmpeg configure.

Instead of having MythTV configure do all the work that is needed for
FFmpeg, rather have MythTV configure invoke the FFmpeg configure.
This eliminates the need to keep updating MythTV configure with FFmpeg
changes.

There is still FFmpeg code in the MythTV configure. A complete cleanup
would take a lot of work, since some things may be used by MythTV.

Fixes #13259

comment:10 Changed 2 years ago by Peter Bennett <pbennett@…>

In 3b246a121/mythtv:

Fix bug in configure where FFmpeg header files are deployed to the wrong directory

Refactor of configure cause ffmpeg header files to be stored in /usr/include
instead of /usr/include/mythtv

Refs #13259

comment:11 Changed 2 years ago by Peter Bennett <pbennett@…>

In 65c5841a02/mythtv:

configure: Add back enable-sdl option and building of mythffplay

configure refactor had removed the enable-sdl option, but this is used
in the deb package build.

Refs #13259

comment:12 Changed 2 years ago by Peter Bennett <pbennett@…>

In e9fb6fb44/mythtv:

Prevent installation of FFmpeg examples and pkgconfig files

configure refactor had caused these unneeded items to be installed with FFmpeg.

Refs #13259

comment:13 Changed 2 years ago by Peter Bennett <pbennett@…>

In e9fb6fb44/mythtv:

Prevent installation of FFmpeg examples and pkgconfig files

configure refactor had caused these unneeded items to be installed with FFmpeg.

Refs #13259

comment:14 Changed 2 years ago by Peter Bennett <pbennett@…>

In 65c5841a02/mythtv:

configure: Add back enable-sdl option and building of mythffplay

configure refactor had removed the enable-sdl option, but this is used
in the deb package build.

Refs #13259

comment:15 Changed 2 years ago by Peter Bennett <pbennett@…>

In 3b246a121/mythtv:

Fix bug in configure where FFmpeg header files are deployed to the wrong directory

Refactor of configure cause ffmpeg header files to be stored in /usr/include
instead of /usr/include/mythtv

Refs #13259

comment:16 Changed 2 years ago by Peter Bennett <pbennett@…>

In 9563786648/mythtv:

Decouple MythTV configure from FFmpeg configure.

Instead of having MythTV configure do all the work that is needed for
FFmpeg, rather have MythTV configure invoke the FFmpeg configure.
This eliminates the need to keep updating MythTV configure with FFmpeg
changes.

There is still FFmpeg code in the MythTV configure. A complete cleanup
would take a lot of work, since some things may be used by MythTV.

Fixes #13259

Note: See TracTickets for help on using tickets.