Opened 6 years ago
Closed 6 years ago
Last modified 6 years ago
#13262 closed Patch - Bug Fix (fixed)
Freetype2 v.2.9.1 deprecates freetype-configure, breaking the config script
Reported by: | Taijian | Owned by: | Peter Bennett |
---|---|---|---|
Priority: | major | Milestone: | 29.2 |
Component: | MythTV - configure script | Version: | v29.1 |
Severity: | high | Keywords: | |
Cc: | Ticket locked: | no |
Description
Arch Linux updated to freetype2 v.2.9.1 on May 2nd, introducing a change that confuses and breaks MythTV's configure script, because as of v2.9.1 freetype2 deprecates the 'freetype-config' command, which is used in several places by configure.
A proposed patch is attached and builds on my system (Arch Linux as of May 3rd, 2018).
Attachments (3)
Change History (13)
Changed 6 years ago by
Attachment: | freetype2.patch added |
---|
comment:1 Changed 6 years ago by
Milestone: | unknown → 30.0 |
---|---|
Owner: | changed from JYA to Peter Bennett |
Status: | new → assigned |
Changed 6 years ago by
Attachment: | 20180509_1445_configure_v29_freetype.patch added |
---|
Fix backported from master
comment:2 Changed 6 years ago by
Status: | assigned → accepted |
---|
This has already been fixed in MythTV master branch, in a different way. Attached patch (20180509_1445_configure_v29_freetype.patch) backports the fix to V29. Please revert your patch, test this new patch and let us know if it works.
comment:3 Changed 6 years ago by
Milestone: | 30.0 → 29.2 |
---|
comment:4 Changed 6 years ago by
OK, I tried out your patch, but it failed to compile, because you missed something.
Add the following to your patch, and you're golden.
@@ -8571,8 +8570,8 @@ fi if enabled freetype2; then - echo "FREETYPE_CFLAGS=`freetype-config --cflags`" >> $TMPMAK - echo "FREETYPE_LIBS=`freetype-config --libs`" >> $TMPMAK + echo "FREETYPE_CFLAGS=$($pkg_config --cflags $pkg_config_flags freetype2)" >> $TMPMAK + echo "FREETYPE_LIBS=$($pkg_config --libs $pkg_config_flags freetype2)" >> $TMPMAK fi if test $target_os = darwin; then
Changed 6 years ago by
Attachment: | 20180509_1744_configure_v29_freetype.patch added |
---|
Amended patch with additional fix for freetype-config
comment:5 Changed 6 years ago by
Thank you for finding that. Revised patch is attached. That fix was also not in master, so I will apply it there as well.
comment:6 Changed 6 years ago by
You're welcome, and thank you and all the others for working on mythtv!
patch to fix building with freetype2 v2.9.1+