Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#13272 closed Patch - Feature (fixed)

Code cleanup - change shebang from /usr/bin/env perl to /usr/bin/perl

Reported by: Gary Buhrmaster Owned by: David Hampton
Priority: minor Milestone: unknown
Component: MythTV - General Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Use of /usr/bin/env has a storied discussion, but is considered ill advised by some. For all the perl code in the main sources the shebang specifies /usr/bin/perl with the exception of the following two files. Some build processes report a warning of the use of /usr/bin/env (and/or modify it to meet the package standards). Patch follows to change these two exceptions in the source to be /usr/bin/perl.

Proposed patch: 

diff --git a/mythtv/programs/scripts/internetcontent/topdocumentaryfilm.pl b/mythtv/programs/scripts/internetcontent/topdocumentaryfilm.pl
index ea5110d877..d44e023860 100755
--- a/mythtv/programs/scripts/internetcontent/topdocumentaryfilm.pl
+++ b/mythtv/programs/scripts/internetcontent/topdocumentaryfilm.pl
@@ -1,4 +1,4 @@
-#!/usr/bin/env perl
+#!/usr/bin/perl
 # @(#)$Header: /home/mythtv/mythtvrep/scripts/topdocumentaryfilm.pl,v 1.17 2010/07/24 23:28:11 mythtv Exp $
 # Auric 2010/01/10 http://web.aanet.com.au/auric/
 #
diff --git a/mythtv/programs/scripts/internetcontent/twit.tv.pl b/mythtv/programs/scripts/internetcontent/twit.tv.pl
index e040d4c29a..c472b3c58d 100755
--- a/mythtv/programs/scripts/internetcontent/twit.tv.pl
+++ b/mythtv/programs/scripts/internetcontent/twit.tv.pl
@@ -1,4 +1,4 @@
-#!/usr/bin/env perl
+#!/usr/bin/perl
 # @(#)$Header: /home/mythtv/mythtvrep/scripts/twit.tv.pl,v 1.34 2015/11/04 11:29:00 mythtv Exp $
 # Auric 2010/01/10 http://web.aanet.com.au/auric/
 #

Change History (3)

comment:1 Changed 6 years ago by David Hampton

Owner: set to David Hampton
Status: new → accepted

comment:2 Changed 6 years ago by David Hampton <mythtv@…>

Resolution: → fixed
Status: accepted → closed

In b64faea20b/mythtv:

Change shebang from '/usr/bin/env perl' to /usr/bin/perl.

Use of /usr/bin/env has a storied discussion, but is considered ill
advised by some. For all the perl code in the main sources the shebang
specifies /usr/bin/perl with the exception of the following two
files. Some build processes report a warning of the use of
/usr/bin/env (and/or modify it to meet the package standards).

Patch from Gary Buhrmaster, fixes #13272.

comment:3 Changed 6 years ago by David Hampton <mythtv@…>

In b64faea20b/mythtv:

Change shebang from '/usr/bin/env perl' to /usr/bin/perl.

Use of /usr/bin/env has a storied discussion, but is considered ill
advised by some. For all the perl code in the main sources the shebang
specifies /usr/bin/perl with the exception of the following two
files. Some build processes report a warning of the use of
/usr/bin/env (and/or modify it to meet the package standards).

Patch from Gary Buhrmaster, fixes #13272.

Note: See TracTickets for help on using tickets.