Opened 19 months ago

Closed 19 months ago

Last modified 17 months ago

#13275 closed Patch - Bug Fix (fixed)

FFmpeg files not installed in configure --libdir-name

Reported by: Gary Buhrmaster Owned by: Peter Bennett
Priority: minor Milestone: 30.0
Component: MythTV - configure script Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

With recent changes to configure for FFmpeg configure separation, the external/FFmpeg libraries are no longer installed in the --libdir-name directory as specified by configure, resulting in interesting install locations.

If (for example), one specifies ./configure --libdir-name=lib64 (a configuration not totally unexpected on x86_64 systems) all mythtv libraries are installed in .../lib64 (as expected), but the FFmpeg ones are installed in .../lib (not expected).

Proposed patch (extremely lightly tested (it compiled and the files look to be in the right place, but completely operationally untested)) below.

diff --git a/mythtv/configure b/mythtv/configure
index a378fc44dd..0a307557e9 100755
--- a/mythtv/configure
+++ b/mythtv/configure
@@ -6956,7 +6956,7 @@ ffmpeg_optenable() {
 ffopts=
 ffmpeg_optset arch cross_prefix sysroot sysinclude cc cxx ld cpu
 ffmpeg_optset extra_cxxflags extra_ldflags target_os
-ffmpeg_optset pkg_config prefix as objcc dep_cc host_cc
+ffmpeg_optset pkg_config prefix libdir as objcc dep_cc host_cc
 ffmpeg_optset host_ld
 ffmpeg_optenable cross_compile libmp3lame libx264 libx265 libvpx libxvid
 ffmpeg_optenable vdpau vaapi libxml2 libass dxva2 mediacodec

Change History (4)

comment:1 Changed 19 months ago by Peter Bennett

Owner: changed from JYA to Peter Bennett
Status: newassigned

comment:2 Changed 19 months ago by Peter Bennett

Milestone: needs_triage30.0
Status: assignedaccepted

comment:3 Changed 19 months ago by Gary Buhrmaster <gary.buhrmaster@…>

Resolution: fixed
Status: acceptedclosed

In 240342728/mythtv:

configure: Fix error where libdir is not honored for ffmpeg libraries

configure parameter libdir-name specifies a directory for libraries, and was not
working correctly.

Fixes #13275

Signed-off-by: Peter Bennett <pbennett@…>

comment:4 Changed 17 months ago by Gary Buhrmaster <gary.buhrmaster@…>

In 240342728/mythtv:

configure: Fix error where libdir is not honored for ffmpeg libraries

configure parameter libdir-name specifies a directory for libraries, and was not
working correctly.

Fixes #13275

Signed-off-by: Peter Bennett <pbennett@…>

Note: See TracTickets for help on using tickets.