Opened 5 years ago
Closed 5 years ago
Last modified 5 years ago
#13322 closed Patch - Bug Fix (fixed)
gdb not working for android 5.1 in amazon fire stick
Reported by: | Peter Bennett | Owned by: | Mark Spieth |
---|---|---|---|
Priority: | minor | Milestone: | 30.0 |
Component: | Ports - Android | Version: | Master Head |
Severity: | medium | Keywords: | |
Cc: | Ticket locked: | no |
Description
Some adb commands work differently in the amazon version of android 5.1.
- adb shell run-as $PACKAGE_NAME fails if you follow it with a shell internal command. you have to use adb shell run-as $PACKAGE_NAME sh -c
- An extra carriage return is attached to the result of pwd
- adb shell <command> always returns zero even if the command returned nonzero, so you have to add ;echo $? and capture the result.
Fixes are in attached patch.
Also added quotes around $ARM64 in one place so that there is not a failure when ARM64 is unvalued.
The fixes are also compatible with newer android versions.
Attachments (1)
Change History (4)
Changed 5 years ago by
Attachment: | 20180925_1334_gdb_fix.patch added |
---|
comment:1 Changed 5 years ago by
the stripping of lf at end of line is wrong. what it will do is strip all whitespace. Any path with whitespace will be wrong.
Otherwise LGTM. Fix and ship.
comment:3 Changed 5 years ago by
Milestone: | needs_triage → 30.0 |
---|
Note: See
TracTickets for help on using
tickets.
fix for gdb.sh