Opened 14 months ago

Closed 13 months ago

Last modified 12 months ago

#13323 closed Bug Report - General (fixed)

Cleanup key press handling in MythMusic

Reported by: David Hampton Owned by: David Hampton
Priority: minor Milestone: 30.0
Component: Plugin - MythMusic Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Every key press handler in MythMusic explicitly calls both its parent handler and its grandparent handler. Make the parent handler call up like it normally should, instead of requiring every caller to call its grandparent.

Change History (3)

comment:1 Changed 13 months ago by David Hampton

Resolution: Fixed
Status: assignedclosed

Fixed in commit [a2cb1e42fb]

comment:2 Changed 12 months ago by David Hampton <mythtv@…>

Resolution: Fixedfixed

In a2cb1e42fb/mythtv:

MusicCommon::keyPressEvent should call its parent.

This cleans up the code, since each of its callers doesn't have to
explicitly call both its parent (this function) and its grandparent.

This issue was pointed out by the clang-tidy
bugprone-parent-virtual-call check.

Fixes #13323

comment:3 Changed 12 months ago by David Hampton <mythtv@…>

In a2cb1e42fb/mythtv:

MusicCommon::keyPressEvent should call its parent.

This cleans up the code, since each of its callers doesn't have to
explicitly call both its parent (this function) and its grandparent.

This issue was pointed out by the clang-tidy
bugprone-parent-virtual-call check.

Fixes #13323

Note: See TracTickets for help on using tickets.