Opened 6 years ago
Closed 5 years ago
Last modified 5 years ago
#13329 closed Patch - Feature (fixed)
Proposed patch - External recorder channel change can result in discontinuous changes for LiveTV
Reported by: | Gary Buhrmaster | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | 30.0 |
Component: | MythTV - Video Library | Version: | Master Head |
Severity: | medium | Keywords: | |
Cc: | Ticket locked: | no |
Description
For your consideration:
During some testing of LiveTV with an external recorder (limited testing, I almost never use LiveTV) I encountered some non-reproducible issues with channel changes and video failures. I originally thought I had tracked them down to changes in video format between the channels, and applied the following patch, which seemed to help at least a few times.
Eventually I also made other changes to my external recorder to eliminate certain other channel change artifacts.
I have been unable to reproduce the original problem with or without this patch since I made those other changes to my external recorder. But this feels like it should be the correct value for the general case of external recorders and LiveTV.
diff --git a/mythtv/libs/libmythtv/cardutil.h b/mythtv/libs/libmythtv/cardutil.h index b19c5b40ff..23f07bdd41 100644 --- a/mythtv/libs/libmythtv/cardutil.h +++ b/mythtv/libs/libmythtv/cardutil.h @@ -139,7 +139,8 @@ class MTV_PUBLIC CardUtil static bool IsChannelChangeDiscontinuous(const QString &rawtype) { - return !IsEncoder(rawtype) || (rawtype == "HDPVR"); + return !IsEncoder(rawtype) || (rawtype == "HDPVR") || + (rawtype == "EXTERNAL"); } static bool IsUnscanable(const QString &rawtype)
Fixed by 6cc3926e.
Thanks Gary.