Opened 12 months ago

Closed 12 months ago

Last modified 12 months ago

#13333 closed Bug Report - General (fixed)

mythtv master fails to build with recent changes to ExternalRecorder

Reported by: Mike Bibbings Owned by: Stuart Auchterlonie
Priority: major Milestone: 30.0
Component: MythTV - General Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Local source build on master fails to build on Xubuntu 18.04 and Debian Stretch at commit f46e781a04ec2ac345dbf7ceda08ae91362d9081

First build failure is at :

recorders/ExternalStreamHandler.cpp: In member function ‘int ExternIO::Read(QByteArray&, int, int)’:
recorders/ExternalStreamHandler.cpp:146:22: error: ‘std::this_thread’ has not been declared
                 std::this_thread::sleep_for(std::chrono::milliseconds(100));
                      ^~~~~~~~~~~
recorders/ExternalStreamHandler.cpp: In member function ‘virtual void ExternalStreamHandler::run()’:
recorders/ExternalStreamHandler.cpp:640:30: error: ‘std::this_thread’ has not been declared
                         std::this_thread::sleep_for(std::chrono::seconds(5));
                              ^~~~~~~~~~~
recorders/ExternalStreamHandler.cpp:664:30: error: ‘std::this_thread’ has not been declared
                         std::this_thread::sleep_for(std::chrono::seconds(5));
                              ^~~~~~~~~~~
Makefile:18135: recipe for target 'obj/ExternalStreamHandler.o' failed
make[2]: *** [obj/ExternalStreamHandler.o] Error 1
make[2]: Leaving directory '/srv/mike/build/mythtv/mythtv/libs/libmythtv'
Makefile:265: recipe for target 'sub-libmythtv-make_first' failed
make[1]: *** [sub-libmythtv-make_first] Error 2
make[1]: Leaving directory '/srv/mike/build/mythtv/mythtv/libs'
Makefile:68: recipe for target 'libs' failed
make: *** [libs] Error 2

It appears that <thread> include is missing. Attached is a patch which adds #include <thread> to two files. I don't know if this general solution, it fixes Xubuntu 18.04 and Debian Stretch.

Attachments (1)

add_thread.patch (904 bytes) - added by Mike Bibbings 12 months ago.
add_thread patch

Download all attachments as: .zip

Change History (4)

Changed 12 months ago by Mike Bibbings

Attachment: add_thread.patch added

add_thread patch

comment:1 Changed 12 months ago by Stuart Auchterlonie

Owner: set to Stuart Auchterlonie
Status: newaccepted

Thanks for the patch. I was just looking into this issue.

Regards Stuart

comment:2 Changed 12 months ago by Mike Bibbings <mike.bibbings@…>

Resolution: fixed
Status: acceptedclosed

In 130b0667c/mythtv:

Fixes #13333 - Fix build failure by including <thread>

Signed-off-by: Stuart Auchterlonie <stuarta@…>

comment:3 Changed 12 months ago by Mike Bibbings <mike.bibbings@…>

In 130b0667c/mythtv:

Fixes #13333 - Fix build failure by including <thread>

Signed-off-by: Stuart Auchterlonie <stuarta@…>

Note: See TracTickets for help on using tickets.