Opened 3 months ago

Closed 7 weeks ago

Last modified 7 weeks ago

#13347 closed Bug Report - General (fixed)

lyrics: letssingit false postives

Reported by: ijc Owned by: paulh
Priority: major Milestone: 30.0
Component: Plugin - MythMusic Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

The letssingit lyrics grabber always returns success (and a mostly empty boilerplate xml result) even when it has found nothing. This makes the frontend stop scanning grabbers at that point and just show an empty lyrics page from letssingit, even if subsequent grabbers would have succeeded.

In fact I have never seen the letssingit search succeed and when I visit the URL which the script is hitting e.g. https://search.letssingit.com/?a=search&l=song&s=The+Beatles+Hey+Jude with FireFox? I get presented with a "Prove you aren't a robot" captcha thing. Or I did earlier today -- right now the site simply isn't responding from my IP although it is from my VPS -- I suspect I have failed the test and been blacklisted!

I'm not sure we can (or should) bypass the captcha so I will attach a patch which drops this particular lyrics grabber (AFAICT just removing the file is enough, there is no listing in a .pro file etc to be removed).

Attachments (1)

0001-mythmusic-Remove-letssingit-grabber.patch (7.3 KB) - added by ijc 3 months ago.

Download all attachments as: .zip

Change History (4)

Changed 3 months ago by ijc

comment:1 Changed 7 weeks ago by paul-h

Resolution: Fixed
Status: newclosed

Fixed by [aec9d9001a]

comment:2 Changed 7 weeks ago by Stuart Auchterlonie

Milestone: needs_triage30.0

comment:3 Changed 7 weeks ago by Paul Harrison <pharrison@…>

Resolution: Fixedfixed

In aec9d9001/mythtv:

MythMusic: Remove no longer working letssingit lyrics grabber

Closes #13347

Note: See TracTickets for help on using tickets.