Opened 2 years ago
Closed 18 months ago
Last modified 14 months ago
#13406 closed Patch - Bug Fix (fixed)
Patches to fix php count warnings with PHP 7.2
Reported by: | daraden | Owned by: | Stuart Auchterlonie |
---|---|---|---|
Priority: | minor | Milestone: | 30.1 |
Component: | Plugin - MythWeb | Version: | Master Head |
Severity: | low | Keywords: | |
Cc: | Ticket locked: | no |
Description
These patches are to resolve count() warnings when using PHP 7.2. Changes just check if the object is not null before calling the count function, otherwise the count variable is set to 0.
link to PHP manual noting the count() behavior as an incompatible change in PHP 7.2https://secure.php.net/manual/en/migration72.incompatible.php
Attachments (2)
Change History (12)
Changed 2 years ago by
Attachment: | mythcount.patch added |
---|
comment:2 Changed 2 years ago by
Milestone: | needs_triage → 30.1 |
---|---|
Status: | new → accepted |
Needs backporting to fixes/29 and fixes/30
comment:3 Changed 2 years ago by
Don't know if it's the right way but I "fixed" this on Fedora using the following:
iff --git a/modules/tv/tmpl/default/detail.php b/modules/tv/tmpl/default/detail.php index f6d1faa9..4975f415 100644 --- a/modules/tv/tmpl/default/detail.php +++ b/modules/tv/tmpl/default/detail.php @@ -842,7 +842,7 @@ } echo ' </ul>'; } - if (count($program->jobs['queue'])) { + if (is_array($program->jobs['queue']) && count($program->jobs['queue'])) { echo t('Queued jobs'), ':', ' <ul class="-queued">'; foreach ($program->jobs['queue'] as $job) { @@ -856,7 +856,7 @@ } echo ' </ul>'; } - if (count($program->jobs['done'])) { + if (is_array($program->jobs['done']) && count($program->jobs['done'])) { echo t('Recently completed jobs'), ':', ' <ul class="-done">'; foreach ($program->jobs['done'] as $job) {
comment:4 Changed 2 years ago by
Would it be safe to apply the two patches to v30? I would like to fix this for Fedora / RPM Fusion.
comment:5 Changed 2 years ago by
Should work fine with v30(patches are working on my 29 backend). files the patches modify are listed as last modified 2 or more years ago.
comment:6 Changed 22 months ago by
Per the following thread in the forum ( https://forum.mythtv.org/viewtopic.php?p=13823#p13823 ) the count error also affects the file Mythbackend.php as follows:
Warning at /usr/share/mythtv/bindings/php/MythBackend.php, line 194: NoTrans: count(): Parameter must be an array or an object that implements Countable!!
comment:9 Changed 18 months ago by
Resolution: | → fixed |
---|---|
Status: | accepted → closed |
In dc87fada5/mythtv:
mythtv php bindings count patch