Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#13419 closed Bug Report - General (fixed)

Jerky playback with shield on certain interlaced content

Reported by: mspieth Owned by: Peter Bennett
Priority: minor Milestone: 30.1
Component: Ports - Android Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Some recordings are giving extremely jerky playback.

The log shows that the video is being re-initialized around twice every second.

Attachments (2)

20190303_1520_video_reinit_bug.patch​ (770 bytes) - added by Peter Bennett 5 years ago.
Fix for repeated video reinitialization bug
20190304_1720_video_reinit_bug.patch​ (586 bytes) - added by Peter Bennett 5 years ago.
Replacement for the previous patch. Hopefully this fixes it for all recordings.

Download all attachments as: .zip

Change History (8)

Changed 5 years ago by Peter Bennett

Attachment: 20190303_1520_video_reinit_bug.patch​ added

Fix for repeated video reinitialization bug

comment:1 Changed 5 years ago by Peter Bennett

Reporter: changed from Peter Bennett to mspieth
Status: assigned → accepted

The logic is continuously flipping between 25fps and 50fps and each time is re-initializing video.

The fix changes the order of fields used to determine framerate to give r_frame_rate a lower priority. r_frame_rate is described as the lowest possible frame rate. not the actual frame rate and was showing as 50. I think the description actually means highest possible frame rate, lowest frame interval

This fixes playback for Mark's sample file.

comment:2 Changed 5 years ago by mspieth

Tested with another 2 programs which is still very jerky. Tried at 1.0 and 1.5x.

1013_20190303003000.ts (another sports 6.5h)

also another style of program

1013_20190303100000.ts (chat show style) 1h

Changed 5 years ago by Peter Bennett

Attachment: 20190304_1720_video_reinit_bug.patch​ added

Replacement for the previous patch. Hopefully this fixes it for all recordings.

comment:3 Changed 5 years ago by Peter Bennett

This bug actually manifests on all decoders that have built in deinterlace - medicodec, nvdec, vaapi2. It also manifests on avsync as well as avsync2.

The new patch fixes it on the original video as well as the two new videos from Mark.

comment:4 Changed 5 years ago by mspieth

Looks good so far.

comment:5 Changed 5 years ago by Peter Bennett <pbennett@…>

Resolution: → fixed
Status: accepted → closed

In 0e7e57f9c2/mythtv:

Playback: Fix jerkiness with codec-deinterlaced content

Remove unneeded setting of m_fps that was overwriting the correct
value. m_fps is suppsed to contain the framerate before deinterlacing.

Fixes #13419

comment:6 Changed 5 years ago by Peter Bennett <pbennett@…>

In 76ea9755b/mythtv:

Playback: Fix jerkiness with codec-deinterlaced content

Remove unneeded setting of m_fps that was overwriting the correct
value. m_fps is suppsed to contain the framerate before deinterlacing.

Fixes #13419

(cherry picked from commit 0e7e57f9c2eb0e2c4f47dcb30788a4e54d6808ba)

Note: See TracTickets for help on using tickets.