Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#13435 closed Bug Report - Memory Leak (fixed)

Potential memory leak in DecodeData function.

Reported by: David Hampton Owned by: David Hampton
Priority: minor Milestone: 30.1
Component: MythTV - General Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

If the padding after the decryption has an invalid size, the function exits without freeing the temporary decryption buffer.

Change History (2)

comment:1 Changed 5 years ago by David Hampton <mythtv@…>

Resolution: → fixed
Status: assigned → closed

In 221e867bcb/mythtv:

tidy: Fix memory leak in HLSSegment::DecodeData?.

The clang-tidy "memory leak" checker pointed out that
HLSSegment::DecodeData? function would leak memory if it read an
invalid padding size from the end of the buffer. Add a line to free
the temporary buffer in this error condition.

Fixes #13435.

comment:2 Changed 5 years ago by David Hampton <mythtv@…>

In 094e0d0c80/mythtv:

tidy: Fix memory leak in HLSSegment::DecodeData?.

The clang-tidy "memory leak" checker pointed out that
HLSSegment::DecodeData? function would leak memory if it read an
invalid padding size from the end of the buffer. Add a line to free
the temporary buffer in this error condition.

Fixes #13435.

(cherry picked from commit 221e867bcbf5a79ff5f68eb5d30aa78538a2dbfb)

Note: See TracTickets for help on using tickets.