Opened 7 months ago

Closed 7 months ago

#13442 closed Patch - Bug Fix (fixed)

mythplayer doesn't properly check for in progress

Reported by: David Hampton Owned by: David Hampton
Priority: minor Milestone: 30.1
Component: MythTV - General Version: v30-fixes
Severity: medium Keywords:
Cc: Ticket locked: no

Description (last modified by David Hampton)

There are two places where the code doesn't properly compute the isInProgress variable, always computing the value 'true'. This variable is only used as an argument to SubtitleReader::LoadExternalSubtitles, so the problem may not have had a visible effect.

Attachments (1)

mythplayer.cpp.diff (1.6 KB) - added by David Hampton 7 months ago.

Download all attachments as: .zip

Change History (3)

Changed 7 months ago by David Hampton

Attachment: mythplayer.cpp.diff added

comment:1 Changed 7 months ago by David Hampton

Description: modified (diff)
Summary: MythPlayer::JumpToProgram doesn't properly check for in progressmythplayer doesn't properly check for in progress

comment:2 Changed 7 months ago by David Hampton <mythtv@…>

Resolution: fixed
Status: assignedclosed

In 0bf0880d3e/mythtv:

Fix "in progress" check in mythplayer.

The clang-tidy "implicit boolean conversion" check pointed out a
couple of nonsensical implicit conversion from TVState to boolean.
Fix the code to properly test for one of two TV watching states.

Fixes #13442.

https://clang.llvm.org/extra/clang-tidy/checks/readability-implicit-bool-conversion.html

Note: See TracTickets for help on using tickets.