Opened 11 months ago

Closed 9 months ago

Last modified 6 months ago

#13454 closed Bug Report - General (Fixed)

User interface problems on android

Reported by: Peter Bennett Owned by: Peter Bennett
Priority: minor Milestone: 30.1
Component: Ports - Android Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

  1. Guide grid is monochrome on android. Error message in log states

MythUIGuideGrid: unable to open 'assets:/mythtv/themes/default/categoies.xml'

  1. Skip time minutes has only 1 digit.
  1. Episode ordering incorrect.

Change History (10)

comment:1 Changed 10 months ago by mspieth

Skip issue is incorrect arg(int, ...) usage. The 3rd parameter must be radix, not '0' which results in radix 32.

comment:2 Changed 10 months ago by jpilk

I'll claim responsibility for the typo in (1). The log refers to this file, which is present in my builds for x86_64

/usr/share/mythtv/themes/default/categories.xml

comment:3 Changed 10 months ago by jpilk

I'm running master at Mark's commit 211e648 under Fedora 29 x86_64, Qt version 5.11.3. I didn't see the skip-time problems before, and don't see them now. None of the patches looks Android-specific, but this Ticket is. Are there different default radices?

comment:4 Changed 10 months ago by mspieth

This just jumped out at me as the doco says the 3rd arg param is radix and not fill char. I suspect some compile option in qt enables base 32 support otherwise default becomes base 10 if the specific base is not supported. I have not researched this so it is a big guess. Otherwise I cant see why it shouldn't be the same everywhere.

It seems to also have fixed the incorrect episode ordering, due to the same issue when it generates the sort keys.

I still haven't identified the categories issue yet. It seems like it should open it from the theme cache dir which is not in assets as its downloaded unless the default is used. Perhaps it should use FindThemeFile?() to do the dirty work?

comment:5 Changed 10 months ago by jpilk

I see Android's 'assets' being written to in #13377 and

https://github.com/MythTV/packaging/commit/69ea8df3b026915dee67e18cf1ad2f8874ee2fe0

but AIUI that's during the build. Can it accessed r/w by the user? I would like to run a customised theme - as in http://lists.mythtv.org/pipermail/mythtv-users/2019-June/400653.html

I don't think Android can see the themes in the backend's /usr/share/mythtv/themes

comment:6 Changed 10 months ago by Mark Spieth <mspieth@…>

In 211e648d36/mythtv:

Fix incorrect QString.arg(int,...) usage for fill where radix is missing.

Fixes OSD Skip amount display issue with Qt5.11.3, and possibly others too.
Probably fixes sort issue too.
refs #13454

comment:7 Changed 9 months ago by Peter Bennett

Resolution: Fixed
Status: assignedclosed

Guide grid colors are fixed with commit 9ee9894bf540a6838fe67545de205ffd23acc63f. The other issues are now working correctly.

comment:8 Changed 9 months ago by Peter Bennett <pbennett@…>

In 9ee9894bf/mythtv:

android: Fix problem with guide grid colors.

assets file system does not support file handles.

Refs #13454

comment:9 Changed 9 months ago by Peter Bennett <pbennett@…>

In b9c1b41a6c/mythtv:

android: Fix problem with guide grid colors.

assets file system does not support file handles.

Refs #13454

(cherry picked from commit 9ee9894bf540a6838fe67545de205ffd23acc63f)

comment:10 Changed 6 months ago by Stuart Auchterlonie

Milestone: needs_triage30.1
Note: See TracTickets for help on using tickets.