Opened 8 months ago

Closed 7 months ago

Last modified 7 months ago

#13520 closed Patch - Feature (fixed)

Feature patch - use internal libbluray for CentOS 8

Reported by: Gary Buhrmaster Owned by: David Hampton
Priority: minor Milestone: 31.0
Component: MythTV - General Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Feature patch - use internal libbluray for CentOS 8

In 54db9139afd44fa46a23b1347a1107f61515148a the preference was to use the system provided libbluray, and for those OS's that should have a current libbluray, require it be installed (or die). However, while 18 months ago presuming CentOS 8 would have a usable libbluray may have made sense, it turns out that it does not(1)(2).  Let's punt by pushing the problem out until CentOS 9.  And if the CentOS 8 situation gets cleaned up at some point, this patch can be reverted.

(1) It's (very) complicated.  And it looks to get differently complicated over the next short time period.

(2) And for those wondering, the CentOS 8 buildbot worker, that has been successfully building MythTV, has had some manual interventions by the provider to allow it to build MythTV without this patch. But that is not likely sustainable in the general case, and not something the project likely wants to promulgate for normal users.

Lightly tested on CentOS 8 running configure.

Proposed patch:

diff --git a/mythtv/configure b/mythtv/configure
index e00418ac13..d05c9436b8 100755
--- a/mythtv/configure
+++ b/mythtv/configure
@@ -5942,7 +5942,7 @@ if enabled libbluray_external; then
                 . /etc/os-release
                 case $ID in
                     centos)
-                        if test $VERSION_ID -gt 7; then
+                        if test $VERSION_ID -gt 8; then
                             die "ERROR: can not find libbluray."
                         fi
                         ;;

Change History (4)

comment:1 Changed 8 months ago by Stuart Auchterlonie

Milestone: needs_triage31.0

comment:2 Changed 8 months ago by David Hampton

Owner: set to David Hampton
Status: newaccepted

comment:3 Changed 7 months ago by Gary Buhrmaster <gary.buhrmaster@…>

Resolution: fixed
Status: acceptedclosed

In 4dadf584b/mythtv:

Use builtin libbluray for Centos8.

This library can easily be built on Centos8, but isn't provided as
part of the distribution. Use the internal version of the library for
now. When the library finally becomes available in the distro, revert
this patch.

Fixes #13520.

Signed-off-by: David Hampton <mythtv@…>

comment:4 Changed 7 months ago by Gary Buhrmaster <gary.buhrmaster@…>

In 4dadf584b/mythtv:

Use builtin libbluray for Centos8.

This library can easily be built on Centos8, but isn't provided as
part of the distribution. Use the internal version of the library for
now. When the library finally becomes available in the distro, revert
this patch.

Fixes #13520.

Signed-off-by: David Hampton <mythtv@…>

Note: See TracTickets for help on using tickets.