Opened 4 years ago
Closed 4 years ago
#13524 closed Patch - Feature (Fixed)
Feature patch - make libavc1394-devel optional for CentOS 8
| Reported by: | Gary Buhrmaster | Owned by: | Stuart Auchterlonie |
|---|---|---|---|
| Priority: | minor | Milestone: | 31.0 |
| Component: | Ansible | Version: | Master Head |
| Severity: | medium | Keywords: | |
| Cc: | Ticket locked: | no |
Description
Do not require installation of the libavc1394-devel package for CentOS 8.
This is another "it's complicated" issue.
Background: With RHEL8 (and CentOS 8), the libavc1394 library is shipped. However, the related -devel package is not. A request ( https://pagure.io/epel/issue/80 ) has been made for RH to include the devel package in the CRB repo, which, when resolved, will eventually be included in the CentOS 8 AppStream? repo(1). However, there is no known schedule(2) for resolution of the CRB build (there are a number of
-devel packages which have been requested to match their shipping libraries for RHEL8).
So, as firewire support is a somewhat targeted requirement, do not require installation support in CentOS 8 ansible at the moment. Once the request for building the -devel library is addressed, this patch can be reverted.
(1) Different name because, apparently, CodeReady? is a service? mark of RH.
(2) These are the times when I miss having a access to a RH TAM to ask for planning (not committed) purposes for scheduling.
Proposed patch follows:
From 90a882371be77c68b4e27eedb2fea0b309d2c212 Mon Sep 17 00:00:00 2001
From: Gary Buhrmaster <gtb@bb0.garybuhrmaster.net>
Date: Thu, 28 Nov 2019 00:45:55 +0000
Subject: [PATCH] do not require libavc1394-devel for CentOS 8
---
roles/mythtv-dnf/tasks/main.yml | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/roles/mythtv-dnf/tasks/main.yml b/roles/mythtv-dnf/tasks/main.yml
index 0909f81..9c53b66 100644
--- a/roles/mythtv-dnf/tasks/main.yml
+++ b/roles/mythtv-dnf/tasks/main.yml
@@ -68,7 +68,6 @@
- libvdpau-devel
- libcec-devel
- libass-devel
- - libavc1394-devel
- libiec61883-devel
- fftw-devel
- libcrystalhd-devel
@@ -79,6 +78,13 @@
- libvpx-devel
- libbluray-bdj
+- name: add optional build libraries - Fedora only
+ set_fact:
+ dnf_pkg_lst:
+ - '{{ dnf_pkg_lst }}'
+ - libavc1394-devel
+ when: ansible_distribution == "Fedora"
+
- name: add mythtv essential python modules
set_fact:
dnf_pkg_lst:
--
2.18.1
Fixed in https://github.com/MythTV/ansible/commit/69d2c7e8fc1c51ec556eb7bc16ecb7bb43942bcc