Opened 4 months ago

Closed 6 weeks ago

Last modified 6 weeks ago

#13534 closed Bug Report - General (fixed)

Cutlist editor OSD: 'current position' marker has become meaningless

Reported by: jpilk Owned by: mark-kendall
Priority: minor Milestone: 31.0
Component: MythTV - General Version: Master Head
Severity: medium Keywords: deletemap.cpp osd.cpp
Cc: Ticket locked: no

Description

I first saw this in 2019-render at commit c794391 of 21 Nov. The build before was 0907c2db of 17 Nov. This interval saw many commits including a merge from master.

The editor and its OSD still work, but the 'current position' mark is always at one end or the other of the progress bar. This is a regression.

http://lists.mythtv.org/pipermail/mythtv-dev/2019-November/077908.html

Attachments (1)

cutlist_editor_position.patch (585 bytes) - added by rcrdnalor 2 months ago.
Fix display of cutlist editor position

Download all attachments as: .zip

Change History (9)

comment:1 Changed 4 months ago by Jonatan Lindblad

It appears it's this cast that is causing the problem https://github.com/MythTV/mythtv/commit/c9c16f40790#diff-715ce5ff3fb7431a0e8fcfac1d732a5eR386

The position is a float between 0.0 and 1.0 so that is why the mark is either at the beginning or the end now when it's cast to an integer.

comment:2 Changed 4 months ago by mark-kendall

Owner: set to mark-kendall
Status: newaccepted

comment:3 Changed 2 months ago by jpilk

Another comment on using the editor: when editing DVB radio recordings with '-v playback' active there is a continuous stream of 'nothing to display' messages. True but excessive. :-)

comment:4 Changed 2 months ago by rcrdnalor

Fix regression to v30: display of position marker

Commit c9c16f40790 applied a wrong cast to long long as outlined in comment:1.

Attached patch reverts this cast.

This is a regression to v30 and should be fixed asap.

Personally, I rely on this feature every day.

Changed 2 months ago by rcrdnalor

Fix display of cutlist editor position

comment:5 Changed 8 weeks ago by Stuart Auchterlonie

Milestone: needs_triage31.0

comment:6 Changed 7 weeks ago by Klaas de Waal

Tested with today's master, the patch does solve the problem.

comment:7 Changed 6 weeks ago by Mark Kendall <mark.kendall@…>

Resolution: fixed
Status: acceptedclosed

In 0e5e52b6f/mythtv:

OSD: Fix edit bar positioning

  • use the correct cast to call the correct method
  • fixes #13534

comment:8 Changed 6 weeks ago by Mark Kendall <mark.kendall@…>

In b394f0981d/mythtv:

OSD: Fix edit bar positioning

  • use the correct cast to call the correct method
  • fixes #13534
Note: See TracTickets for help on using tickets.