Opened 4 years ago
Closed 4 years ago
Last modified 4 years ago
#13534 closed Bug Report - General (fixed)
Cutlist editor OSD: 'current position' marker has become meaningless
Reported by: | jpilk | Owned by: | Mark Kendall |
---|---|---|---|
Priority: | minor | Milestone: | 31.0 |
Component: | MythTV - General | Version: | Master Head |
Severity: | medium | Keywords: | deletemap.cpp osd.cpp |
Cc: | Ticket locked: | no |
Description
I first saw this in 2019-render at commit c794391 of 21 Nov. The build before was 0907c2db of 17 Nov. This interval saw many commits including a merge from master.
The editor and its OSD still work, but the 'current position' mark is always at one end or the other of the progress bar. This is a regression.
http://lists.mythtv.org/pipermail/mythtv-dev/2019-November/077908.html
Attachments (1)
Change History (9)
comment:1 Changed 4 years ago by
comment:2 Changed 4 years ago by
Owner: | set to Mark Kendall |
---|---|
Status: | new → accepted |
comment:3 Changed 4 years ago by
Another comment on using the editor: when editing DVB radio recordings with '-v playback' active there is a continuous stream of 'nothing to display' messages. True but excessive. :-)
comment:4 Changed 4 years ago by
Fix regression to v30: display of position marker
Commit c9c16f40790 applied a wrong cast to long long
as outlined in comment:1.
Attached patch reverts this cast.
This is a regression to v30 and should be fixed asap.
Personally, I rely on this feature every day.
Changed 4 years ago by
Attachment: | cutlist_editor_position.patch added |
---|
Fix display of cutlist editor position
comment:5 Changed 4 years ago by
Milestone: | needs_triage → 31.0 |
---|
It appears it's this cast that is causing the problem https://github.com/MythTV/mythtv/commit/c9c16f40790#diff-715ce5ff3fb7431a0e8fcfac1d732a5eR386
The position is a float between 0.0 and 1.0 so that is why the mark is either at the beginning or the end now when it's cast to an integer.