mythfrontend seg fault Live TV and Recording Playback

[Mike Bibbings]

I am seeing mythfrontend seg fault on UK TV Channels which have mheg active, this affects both Live TV and recording playback on both DVB-T2 and DVB-S2.

Disabling "Enable interactive TV" in mythfrontend setup>Video>Playback OSD stops the seg faults.

Attached are gdb backtrace and mythfrontend log

O/S xubuntu 18.04

mike@mike-GL62-7QF:~$ mythfrontend --version Please attach all output as a file in bug reports. MythTV Version : v31-Pre-1736-gefbc436e33 MythTV Branch : master Network Protocol : 91 Library API : 31.20200101-1 QT Version : 5.9.5 Options compiled in:

linux profile use_hidesyms using_alsa using_oss using_pulse using_pulseoutput using_backend using_bindings_perl using_bindings_python using_bindings_php using_dvb using_firewire using_frontend using_hdhomerun using_vbox using_ceton using_hdpvr using_ivtv using_joystick_menu using_libcec using_libcrypto using_libdns_sd using_libfftw3 using_libxml2 using_lirc using_mheg using_opengl using_egl using_qtwebkit using_qtscript using_qtdbus using_taglib using_v4l2 using_v4l2prime using_x11 using_libbluray_external using_xrandr using_profiletype using_systemd_notify using_systemd_journal using_drm using_bindings_perl using_bindings_python using_bindings_php using_freetype2 using_mythtranscode using_opengl using_opengles using_egl using_drm using_vaapi using_vdpau using_ffmpeg_threads using_mheg using_libass using_libxml2

[David Hampton]

Proposed patch

[David Hampton]

Mike, can you try the proposed patch I just attached to this bug?

[Mike Bibbings]

Patch applied, no more seg faults on Live TV or recording playback and mheg (red button) is working.

Mike

[David Hampton <mythtv@…>]

In 5ec649f7d2/mythtv:

Fix recently introduced crash in MHEG.

The automatic clang-tidy loop modernize-loop-convert changes caused a
situation where while walking an array the current item was set to
null before it was processed. Move this assignment to the end of the
loop.

Fixes #13551.