Opened 7 months ago

Closed 7 months ago

#13584 closed Bug Report - General (Fixed)

Debian: MythGame is not built since v30

Reported by: rcrdnalor Owned by:
Priority: minor Milestone: 30.1
Component: Packaging Version: v30-fixes
Severity: medium Keywords: MythGame
Cc: Ticket locked: no

Description

Build logs of mythbuntu ppa shows:

minizip required to compile mythgame
MythGame       plugin will not be built

Obviously, the following package is missing for building: Package in universe: libminizip-dev

And to install MythGame?, one need libminizip1.

Commit [2a880cd970a34105456ae9024760161cf58ea71f] introduced minizip, but did not change the build dependencies for packaging debian.

Versions affected: master, fixes/31, fixes/30

https://www.mythtv.org/wiki/Build_from_Source does not list this dependency as well, but ansible does.

See https://forum.mythtv.org/viewtopic.php?f=29&t=3246

I will test a patch this evening.

Attachments (2)

mythgame_packaging_debian_master.patch (1.5 KB) - added by rcrdnalor 7 months ago.
Fix build of Mythgame on master for Debian
mythgame_packaging_debian_v30.patch (1.5 KB) - added by rcrdnalor 7 months ago.
Fix build of Mythgame fixes/30 for Debian

Download all attachments as: .zip

Change History (6)

comment:1 Changed 7 months ago by rcrdnalor

Mythgame builds now on Mythtv master for Debian and installs fine.

It is visible in Mythtv's frontend, but I am still hit by #11480.

I needed to adapt the file packaging/deb/debian/changelog.in in a similar way as it was done by commit https://github.com/MythTV/packaging/commit/ce8f164c0b0207f6639bc038f6488f842b7a7619, otherwise on gets deb packages named 'mythgame_31.0~master.2020...amd64.deb' with MythTV v32 content.

Could you please fix that file 'changelog.in' as well?

Attached a patch that fixes build of Mythgame on master for Debian.

Changed 7 months ago by rcrdnalor

Fix build of Mythgame on master for Debian

comment:2 Changed 7 months ago by paul-h

I've fixed changelog.in for both fixes/31 and master.

I've also committed your patch to fix building of MythGame? to master only for now. I assume this will also need to be cherry-picked into fixes/31 as well?

comment:3 Changed 7 months ago by rcrdnalor

Paul,

thank you for taking this ticket.

Today's build of master on mythbuntu ppa 32 builds 'libmythgame.so' correctly.

Please cherry-pick this commit to packaging/fixes/31 branch as well.

Since this this a request of a user on the mythtv-forum against v30, which is our current release, please apply this patch also against fixes/30.

I confirm, that 'minizip', 'libminizip1', 'libminizip-dev' are available in Ubuntu 16.04 up to 20.04.

In case, cherry-picking bails, I'll attach a patch against packaging/fixes/30 as well.

Changed 7 months ago by rcrdnalor

Fix build of Mythgame fixes/30 for Debian

comment:4 Changed 7 months ago by paul-h

Milestone: needs_triage30.1
Resolution: Fixed
Status: newclosed

Committed the fix to fixes/31 and fixes/30.

Note: See TracTickets for help on using tickets.