Opened 4 years ago
Closed 2 years ago
#13592 closed Patch - Feature (Trac EOL)
mythmusic fixes for multiple discs
Reported by: | ijc | Owned by: | paul-h |
---|---|---|---|
Priority: | minor | Milestone: | needs_triage |
Component: | Plugin - MythMusic | Version: | Master Head |
Severity: | medium | Keywords: | |
Cc: | Ticket locked: | no |
Description
Ref: https://github.com/MythTV/mythtv/pull/191
I noticed that mythmusic wasn't handling multi-disc albums correctly.
- the flacvorbis metadata handler didn't know about the
DISCNUMBER
tag so I added it (I addedTOTALTRACKS
andTOTALDISCS
while I was there too). My goto reference for tag names is https://picard.musicbrainz.org/docs/mappings/ (all my music is tagged using Picard so this is what I've ended up with). - once the discnumber was in the DB I noticed that the album sort wasn't handling it correctly, e.g. for a two disc album it would sort disc.track-wise as 1.1, 2.1, 1.2, 2.2, etc rather than 1.1, 1.2, ..., 2.1, 2.2. Incorporate the disc number into the album order to correct this. I believe a single CD can have at most 99 tracks so use a multiplier of 100. This means a 10 disc box set would clash with album map order offset of 1000, so bump that to 10000.
I've been running this on my v30 based production system for a week and have tested against master. I don't know if it is too late for v31.0 but might be nice to have for v31.1?
Attachments (2)
Change History (4)
Changed 4 years ago by
Attachment: | 0001-metaioflacvorbis-handle-DISCNUMBER-and-TOTAL-TRACKS-.patch added |
---|
Changed 4 years ago by
Attachment: | 0002-mythmusic-include-discnumber-in-album-sort-order.patch added |
---|
comment:1 Changed 4 years ago by
Owner: | changed from paulh to paul-h |
---|---|
Status: | new → assigned |
comment:2 Changed 2 years ago by
Resolution: | → Trac EOL |
---|---|
Status: | assigned → closed |
Note: See
TracTickets for help on using
tickets.
We have moved all bug tracking to github [1]
If you continue to have this issue, please open a new issue at github, referencing this ticket.
[1] - https://github.com/MythTV/mythtv/issues