Opened 8 months ago

Last modified 8 months ago

#13592 assigned Patch - Feature

mythmusic fixes for multiple discs

Reported by: ijc Owned by: paul-h
Priority: minor Milestone: needs_triage
Component: Plugin - MythMusic Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Ref: https://github.com/MythTV/mythtv/pull/191

I noticed that mythmusic wasn't handling multi-disc albums correctly.

  • the flacvorbis metadata handler didn't know about the DISCNUMBER tag so I added it (I added TOTALTRACKS and TOTALDISCS while I was there too). My goto reference for tag names is https://picard.musicbrainz.org/docs/mappings/ (all my music is tagged using Picard so this is what I've ended up with).
  • once the discnumber was in the DB I noticed that the album sort wasn't handling it correctly, e.g. for a two disc album it would sort disc.track-wise as 1.1, 2.1, 1.2, 2.2, etc rather than 1.1, 1.2, ..., 2.1, 2.2. Incorporate the disc number into the album order to correct this. I believe a single CD can have at most 99 tracks so use a multiplier of 100. This means a 10 disc box set would clash with album map order offset of 1000, so bump that to 10000.

I've been running this on my v30 based production system for a week and have tested against master. I don't know if it is too late for v31.0 but might be nice to have for v31.1?

Attachments (2)

0001-metaioflacvorbis-handle-DISCNUMBER-and-TOTAL-TRACKS-.patch (1.5 KB) - added by ijc 8 months ago.
0002-mythmusic-include-discnumber-in-album-sort-order.patch (1.5 KB) - added by ijc 8 months ago.

Download all attachments as: .zip

Change History (3)

Changed 8 months ago by ijc

Changed 8 months ago by ijc

comment:1 Changed 8 months ago by Stuart Auchterlonie

Owner: changed from paulh to paul-h
Status: newassigned
Note: See TracTickets for help on using tickets.