Opened 2 years ago

Closed 4 months ago

#13611 closed Patch - Feature (Trac EOL)

MythWeb: Add default sort order to tv/schedules

Reported by: Nigel Jewell Owned by: Stuart Auchterlonie
Priority: minor Milestone: needs_triage
Component: Plugin - MythWeb Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

When a user navigates to /tv/schedules the very first time the results aren't ordered. I believe that it would be good for them to be ordered by title on first.

Exists in master, fixes/31, fixes/30 and maybe others.

Change History (6)

comment:1 Changed 2 years ago by Nigel Jewell

comment:2 Changed 11 months ago by caverndigger88

I was able to add this to my ancient fixes/29 setup...

Only Issue : I have a recording named "The Arrival" ...

When I refresh the "mythweb/tv/schedules" page it puts "The Arrival" on top. If I click on "Title" it puts "The Arrival" down right before "The Outer Limits" .

It should be the same.

since js/table_sort.js has not been updated in like forever... I'm not sure on how to fix it.. Suggestions?

comment:3 Changed 11 months ago by Nigel Jewell

That looks like a separate issue. In my mind, clicking on "title" should not result in everything starting "A " being ordered together, and everything starting "The " ordered together. The "A " and "The " should be ignored. I'll try and identify the cause.

comment:4 Changed 11 months ago by Nigel Jewell

As a side note:

this.callback_presort(table_id, heder_index);

Should be:

this.callback_presort(table_id, header_index);

In js/table_sort.js I suspect. Will come back to this.

comment:5 Changed 11 months ago by Nigel Jewell

@caverndigger88 ... try this change:

https://github.com/mymatenige/mythweb/commit/407113c024b034f5daaafa2ad893bff7f76c89b9

I'm not going to raise a pull request as it's specific to those languages that use A, An, The articles. Nasty side effect of the fact the original code sorts in Javascript.

comment:6 Changed 4 months ago by Stuart Auchterlonie

Resolution: Trac EOL
Status: newclosed

We have moved all bug tracking to github [1]

If you continue to have this issue, please open a new issue at github, referencing this ticket.

[1] - https://github.com/MythTV/mythtv/issues

Note: See TracTickets for help on using tickets.