Opened 4 years ago

Closed 4 years ago

#13612 closed Bug Report - General (fixed)

UPNP: Fix resource duration

Reported by: Nigel Jewell Owned by: David Hampton
Priority: minor Milestone: 31.1
Component: MythTV - UPnP Version: v31-fixes
Severity: medium Keywords:
Cc: Ticket locked: no

Description

In commit 77b560f3cc100717729ed1836367e57ff16c7eb6 a bug was introduced in QString resDurationFormat(uint32_t msec).

The format string of "%01u:%02u:%02u.%01u" should be "%1:%2:%3.%4".

It's been subsequently resolved in c47ae6d443ddd2e305ee862e616e5ad0b0b46509 by removing the need for that format string.

Could this change be also merged into fixes/31? At present resDurationFormat is providing incorrect data to the UPnP client.

Change History (3)

comment:1 Changed 4 years ago by David Hampton

Milestone: needs_triage → 31.1
Owner: changed from dblain to David Hampton
Status: new → assigned

comment:2 Changed 4 years ago by Nigel Jewell

I see this has been fixed in ​https://github.com/MythTV/mythtv/commit/5f1993304e35042192aed059dd7cf8717b76c6a7.

comment:3 Changed 4 years ago by David Hampton <mythtv@…>

Resolution: → fixed
Status: assigned → closed

In 5f1993304/mythtv:

Fix incorrect data provided to UPnP client.

This bug was introduced in 77b560f3cc when converting from the
obsolete QString::sprintf function to typical QString formatting using
QString::arg. In one case the arguments were all converted, but the
format string wasn't . Fix that format string.

Fixes #13612.

Note: See TracTickets for help on using tickets.