Opened 5 weeks ago

Closed 5 weeks ago

Last modified 5 weeks ago

#13625 closed Patch - Bug Fix (fixed)

Insure mythfilldatabase issues reschedule even if --no-mark-repeats is given

Reported by: Gary Buhrmaster Owned by: gigem
Priority: minor Milestone: 31.1
Component: MythTV - Mythfilldatabase Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Insure mythfilldatabase issues reschedule even if --no-mark-repeats is given

Ticket created by request of dev from oob discussion.

Mythfilldatabase currently skips the reschedule if the --no-mark-repeats command line option is given, even if other changes to the program database have occurred (which is likely for any real run with real data).

Mitigation: Don't use --no-mark-repeats (which is likely a very rare use case), or run a separate request (mythutil --resched) to force a reschedule after running mythfilldatabase with --no-mark-repeats.

Lightly tested proposed patch follows:

diff --git a/mythtv/programs/mythfilldatabase/main.cpp b/mythtv/programs/mythfilldatabase/main.cpp
index aa6c33ace2..dba30522f8 100644
--- a/mythtv/programs/mythfilldatabase/main.cpp
+++ b/mythtv/programs/mythfilldatabase/main.cpp
@@ -660,9 +660,8 @@ int main(int argc, char *argv[])
             "| the master backend is restarted.                            |\n"
             "===============================================================");

-    if (mark_repeats)
-        ScheduledRecording::RescheduleMatch(0, 0, 0, QDateTime(),
-                                            "MythFillDatabase");
+    ScheduledRecording::RescheduleMatch(0, 0, 0, QDateTime(),
+                                        "MythFillDatabase");

     gCoreContext->SendMessage("CLEAR_SETTINGS_CACHE");

Change History (4)

comment:1 Changed 5 weeks ago by gigem

Owner: set to gigem
Status: newaccepted

comment:2 Changed 5 weeks ago by Gary Buhrmaster <gary.buhrmaster@…>

Resolution: fixed
Status: acceptedclosed

In 1ba15e5cd/mythtv:

Always request a reschedule when running mythfilldatabase

Previous edits incorrectly left it where the request was only done
when repeats were marked.

Fixes #13625

Signed-off-by: David Engel <dengel@…>

comment:3 Changed 5 weeks ago by Gary Buhrmaster <gary.buhrmaster@…>

In 9380616198/mythtv:

Always request a reschedule when running mythfilldatabase

Previous edits incorrectly left it where the request was only done
when repeats were marked.

Fixes #13625

Signed-off-by: David Engel <dengel@…>
(cherry picked from commit 1ba15e5cdb91f121b60ae96358021d668cf73a71)

comment:4 Changed 5 weeks ago by gigem

Milestone: needs_triage31.1
Note: See TracTickets for help on using tickets.