Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#13632 closed Patch - Feature (fixed)

Resolve TODO in metadatagrabber

Reported by: Gary Buhrmaster Owned by: David Hampton
Priority: minor Milestone: 32.0
Component: MythTV - Mythmetadatalookup Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Resolve TODO in metadatagrabber

In metadatagrabber.cpp there is a comment: 

// TODO
// it would be nice to statically compile these, but I can't manage to get it
// to compile.  apparently initializer lists are supported in QT5/CPP11 that
// will make this work.  for now, use a lock and initialize on first access.

In Qt 5.2 (ish?) Qt added C++11 initializer lists for QMap.

Since recent fixes and master both require both more recent Qt and C++ versions, let us eliminate a legacy TODO.

Lightly tested in a development test environment

Attachments (1)

0001-Resolve-TODO-in-metadatagrabber-to-initialize-static.patch​ (4.2 KB) - added by Gary Buhrmaster 4 years ago.
Resolve TODO in metadatagrabber

Download all attachments as: .zip

Change History (7)

Changed 4 years ago by Gary Buhrmaster

Attachment: 0001-Resolve-TODO-in-metadatagrabber-to-initialize-static.patch​ added

Resolve TODO in metadatagrabber

comment:1 Changed 4 years ago by David Hampton

Owner: set to David Hampton
Status: new → assigned

comment:2 Changed 4 years ago by Stuart Auchterlonie

Milestone: needs_triage → 32.0

comment:3 Changed 4 years ago by Gary Buhrmaster <gary.buhrmaster@…>

Resolution: → fixed
Status: assigned → closed

In d8e6d23077/mythtv:

Resolve TODO in metadatagrabber.cpp using C++ initializer lists.

Signed-off-by: David Hampton <mythtv@…>

Fixes #13632.

comment:4 Changed 4 years ago by Gary Buhrmaster <gary.buhrmaster@…>

In 6e61aa988/mythtv:

Update XMLTV loglevel in programdata

Change the loglevel in programdata to be the same as
EIT updates for the equivalent changes (i.e. debug).
This allows a run of mythfilldatabase with the options
of --verbose general,xmltv with the default loglevel
of info to not blather on about the expected case of
adding, deleting, updating programs (i.e. making the
usage easier to review), but just include the XMLTV
logging that likely matters for the average use case.

Last of four patches. Fixes #13632.

Signed-off-by: David Hampton <mythtv@…>

comment:5 Changed 4 years ago by Gary Buhrmaster <gary.buhrmaster@…>

In d8e6d23077/mythtv:

Resolve TODO in metadatagrabber.cpp using C++ initializer lists.

Signed-off-by: David Hampton <mythtv@…>

Fixes #13632.

comment:6 Changed 4 years ago by Gary Buhrmaster <gary.buhrmaster@…>

In 6e61aa988/mythtv:

Update XMLTV loglevel in programdata

Change the loglevel in programdata to be the same as
EIT updates for the equivalent changes (i.e. debug).
This allows a run of mythfilldatabase with the options
of --verbose general,xmltv with the default loglevel
of info to not blather on about the expected case of
adding, deleting, updating programs (i.e. making the
usage easier to review), but just include the XMLTV
logging that likely matters for the average use case.

Last of four patches. Fixes #13632.

Signed-off-by: David Hampton <mythtv@…>

Note: See TracTickets for help on using tickets.