Opened 3 weeks ago

Last modified 2 weeks ago

#13632 assigned Patch - Feature

Resolve TODO in metadatagrabber

Reported by: Gary Buhrmaster Owned by: David Hampton
Priority: minor Milestone: 32.0
Component: MythTV - Mythmetadatalookup Version: Master Head
Severity: medium Keywords:
Cc: Ticket locked: no


Resolve TODO in metadatagrabber

In metadatagrabber.cpp there is a comment:

// it would be nice to statically compile these, but I can't manage to get it
// to compile.  apparently initializer lists are supported in QT5/CPP11 that
// will make this work.  for now, use a lock and initialize on first access.

In Qt 5.2 (ish?) Qt added C++11 initializer lists for QMap.

Since recent fixes and master both require both more recent Qt and C++ versions, let us eliminate a legacy TODO.

Lightly tested in a development test environment

Attachments (1)

0001-Resolve-TODO-in-metadatagrabber-to-initialize-static.patch (4.2 KB) - added by Gary Buhrmaster 3 weeks ago.
Resolve TODO in metadatagrabber

Download all attachments as: .zip

Change History (3)

Changed 3 weeks ago by Gary Buhrmaster

Resolve TODO in metadatagrabber

comment:1 Changed 3 weeks ago by David Hampton

Owner: set to David Hampton
Status: newassigned

comment:2 Changed 2 weeks ago by Stuart Auchterlonie

Milestone: needs_triage32.0
Note: See TracTickets for help on using tickets.