MacOS Python2.6 hard code breaks python bindings / metadatalookup

[John Hoyt]

There is a hard code to python2.6 in

• mythtv/programs/mythbackend/main.cpp
  
• mythtv/programs/mythfrontend/main.cpp
  
• mythtv/programs/mythmetadatalookup/main.cpp
  

The suspect line in each file is

QString("%1/../Resources/lib/python2.6/site-packages:%2")

This should either be modified to python (per the attached path) or worked out to automatically extract the compile time python version.

[John Hoyt]

potential patch for hardcoded python2.6

[Bill Meek]

John,

I see in compileMythfrontendAnsible.zsh: --python=/opt/local/bin/python3.8

That should end up in libs/libmythbase/mythconfig.h as: #define PYTHON_EXE "/opt/local/bin/python3.8"

Please test this, which removes the leading path info:

diff --git a/mythtv/programs/mythbackend/main.cpp b/mythtv/programs/mythbackend/main.cpp
index 7cf7f5b644..1a6233a7ba 100644
--- a/mythtv/programs/mythbackend/main.cpp
+++ b/mythtv/programs/mythbackend/main.cpp
@@ -94,10 +94,13 @@ int main(int argc, char **argv)
     QCoreApplication::setApplicationName(MYTH_APPNAME_MYTHBACKEND);
 
 #ifdef Q_OS_MAC
+    QFileInfo fi(PYTHON_EXE);
+    QString python_executable = fi.fileName();
     QString path = QCoreApplication::applicationDirPath();
     setenv("PYTHONPATH",
-           QString("%1/../Resources/lib/python2.6/site-packages:%2")
+           QString("%1/../Resources/lib/%2/site-packages:%3")
            .arg(path)
+           .arg(python_executable)
            .arg(QProcessEnvironment::systemEnvironment().value("PYTHONPATH"))
            .toUtf8().constData(), 1);
 #endif

[John Hoyt]

Modified patch for hard code

[John Hoyt]

I just tested this patch file successfully. I believe it still has your debug variable in it for all three files. I needed the mythtv/programs/mythmetadatalookup/main.cpp fix to test easily.

Verified the correct path is being generated by modifying the tmdb3.py script to print its sys.path to a file.

[Bill Meek <billmeek@…>]

In 0add17779/mythtv:

MacOS: remove hard-coded python2.6 PYTHONPATH code

Based on a patch from John Hoyt, and thanks for testing
on MacOS.

This could prevent the location of Python packages in
the future if the OSX packaging sets --python=python
(for example). Currently the version is included in
the Python executable's file name:

--python=/opt/local/bin/python3.8

Fixes #13643

(cherry picked from commit d30fd541c74a37d589548eadb9d225b2a96563ab)

[Bill Meek <billmeek@…>]

In d30fd541c/mythtv:

MacOS: remove hard-coded python2.6 PYTHONPATH code

Based on a patch from John Hoyt, and thanks for testing
on MacOS.

This could prevent the location of Python packages in
the future if the OSX packaging sets --python=python
(for example). Currently the version is included in
the Python executable's file name:

--python=/opt/local/bin/python3.8

Fixes #13643