Opened 14 years ago

Closed 14 years ago

#1399 closed defect (fixed)

NTSC closed captioning on saa7134

Reported by: ovek@… Owned by: danielk
Priority: minor Milestone: 0.20
Component: mythtv Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Please include a patch like this in MythTV. It replaces some hardcoded NTSC closed caption decoder timings with timings calculated from the card's actual VBI sampling rate, much like zvbi does. The rounding I added should make sure the calculations on a bttv card yields the exact same values as were previously used. So it shouldn't have any effect on bttv - but for saa7134, it makes a world of difference. (A world of understanding of what people are saying on TV...)

bttv:

  • sampling rate: 28636363
  • samples per line: 2048
  • sample format: 12
  • start: 10, 273
  • count: 16, 16
  • flags: 0x0

saa7134:

  • sampling rate: 27000000
  • samples per line: 2048
  • sample format: 12
  • start: 10, 273
  • count: 12, 12
  • flags: 0x0

(Put the above data into the related comment in NuppelVideoRecorder?.cpp if you wish.)

Attachments (1)

myth.diff (2.1 KB) - added by ovek@… 14 years ago.
Patch to libmythtv

Download all attachments as: .zip

Change History (3)

Changed 14 years ago by ovek@…

Attachment: myth.diff added

Patch to libmythtv

comment:1 Changed 14 years ago by danielk

Milestone: 0.20
Owner: changed from Isaac Richards to danielk
Version: head

comment:2 Changed 14 years ago by danielk

Resolution: fixed
Status: newclosed

(In [9301]) Closes #1399, by applying patch.

Note: See TracTickets for help on using tickets.