Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#1416 closed enhancement (fixed)

add the ability to choose transcoding profile from PlaybackBox 'i' menu and from OSD

Reported by: spin667@… Owned by: cpinkham
Priority: minor Milestone: unknown
Component: mythtv Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Since the transcoding profile is set at the time the recording is scheduled and there is no easy way to change that after the fact I created this patch to allow the transcoding profile to be changed when Start Transcoding is chosen from the Job Options menu.

There are some minor issues though: doesn't affect the transcode OSD menu, or the 'x' command it always highlights the last item in the list first, why is that?

I'll probably try and add the same choices to the OSD menu, but leave 'x' alone.

I tested this against a slightly older version of svn, and 0.19. It applies and compiles against head but I haven't tested that specific version yet.

Attachments (2)

mythtv-add-transcoder-options-to-playbackbox.diff (4.1 KB) - added by spin667@… 13 years ago.
mythtv-add-transcoder-options-svn.diff (9.0 KB) - added by spin667@… 13 years ago.

Download all attachments as: .zip

Change History (8)

Changed 13 years ago by spin667@…

comment:1 Changed 13 years ago by cpinkham

Owner: changed from Isaac Richards to cpinkham

comment:2 Changed 13 years ago by spin667@…

I've got a version of the patch that adds similar options to the OSD menu. I need to clean it up just a tiny bit and I'll attach that instead.

Changed 13 years ago by spin667@…

comment:3 Changed 13 years ago by spin667@…

added ProgramInfo::ApplyTranscoderProfileChange? to set the transcoder value in the recorded table

added ability to choose transocder in tv_play.cpp and playbackbox.cpp

works well for me...

comment:4 Changed 13 years ago by anonymous

Summary: add the ability to choose transcoding profile from PlaybackBox 'i' menuadd the ability to choose transcoding profile from PlaybackBox 'i' menu and from OSD

comment:5 Changed 13 years ago by cpinkham

Resolution: fixed
Status: newclosed

(In [9679]) Add the ability to choose the transcoding profile from the Watch Recordings 'INFO' popup menu and from the OSD popup menu when scheduling a transcoding job for a recording. Initial patch by spin667, some minor cleanup and conversion to work for MySQL 3.x.x by me. Closes #1416.

comment:6 Changed 13 years ago by Robert Tsai

This patch will not work for people who (legitimately) who much with the database to add more transcoding profiles for themselves (besides the canned "Low", "Medium", and "High" settings). Perhaps the options should have been populated based on values from the database? I don't know how you would them communicate that as a "action" parameter, though. I also don't really care about this feature. But I'm just commenting for the record ...

Note: See TracTickets for help on using tickets.