Opened 15 years ago
Closed 15 years ago
#1430 closed defect (fixed)
couple of compile warnings - patch included
Reported by: | Owned by: | Geoffrey Hausheer | |
---|---|---|---|
Priority: | minor | Milestone: | unknown |
Component: | mythtv | Version: | |
Severity: | medium | Keywords: | |
Cc: | Ticket locked: | no |
Description
Just a trivial patch to eitfixup.cpp, I'm no master coder, but it looks like someone has used a '!=' when meaning to use a '= !'. Patch below fixes the compile warning (gcc 4.0.1/fedora), but I'm not sure if I've screwed the logic up or anything.
Index: eitfixup.cpp =================================================================== --- eitfixup.cpp (revision 9234) +++ eitfixup.cpp (working copy) @@ -290,13 +290,13 @@ // the description as we might destroy other useful information captures = tmpUKCC.capturedTexts(); for (it = captures.begin(); it != captures.end(); ++it) - event.SubTitled != (*it == "S"); + event.SubTitled = !(*it == "S"); } else if ((position = tmpUKCC.search(event.Event_Subtitle)) != -1) { captures = tmpUKCC.capturedTexts(); for (it = captures.begin(); it != captures.end(); ++it) - event.SubTitled != (*it == "S"); + event.SubTitled = !(*it == "S"); // We remove [AD,S] from the subtitle. QString stmp = event.Event_Subtitle;
Change History (4)
comment:1 Changed 15 years ago by
Summary: | compile warnings in eitfixup.cpp - patch included → couple of compile warnings - patch included |
---|
comment:2 Changed 15 years ago by
and also in :
Index: programs/mythtranscode/mpeg2fix.cpp =================================================================== --- programs/mythtranscode/mpeg2fix.cpp (revision 9234) +++ programs/mythtranscode/mpeg2fix.cpp (working copy) @@ -1853,7 +1853,7 @@ PTSdiscrep = 0; break; } - if (tmpPTSdiscrep != AV_NOPTS_VALUE && + if (tmpPTSdiscrep != (int64_t)AV_NOPTS_VALUE && tmpPTSdiscrep != PTSdiscrep) PTSdiscrep = tmpPTSdiscrep; }
comment:3 Changed 15 years ago by
Owner: | changed from Isaac Richards to Geoffrey Hausheer |
---|
The original eitfixup line isn't even in the code anymore. Assigning this ticket to ghaushe to see if this is how he'd prefer to fix the other warnings in mpeg2fix code.
Note: See
TracTickets for help on using
tickets.
a warning is also generated by unsigned->signed comparison in :