Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#1480 closed patch (fixed)

Fix discrepancies in asFileNotFound handling in PlaybackBox

Reported by: sphery <mtdean@…> Owned by: cpinkham
Priority: minor Milestone: unknown
Component: mythtv Version:
Severity: medium Keywords:
Cc: Ticket locked: no

Description

The attached patch fixes discrepancies in the handling of non-existent recordings (as described in http://www.gossamer-threads.com/lists/mythtv/users/188566#188566) in the PlaybackBox (version 0.19 and SVN trunk).

  • Adds a FileNotFoundActionPopup with "Show Program Details" and "Delete"
  • Ensures the FileNotFoundActionPopup is shown for missing files instead of the AvailablePopup
  • Prevents the user from seeing the full ActionPopup the first time, and instead shows the FileNotFoundActionPopup (checks for file existence before showing the Action popup)

(all translations are re-used from the ActionPopup and the AvailablePopup)

I started to send an e-mail to the dev list to get feedback on the desired post-patch behavior, but reading it would have taken longer than it took to make the patch :), so I figured I'd give an initial implementation and take feedback from there. I'll reply to this ticket (on the dev list) with the details/implementation decisions I made for anyone who's interested

Attachments (1)

mythtv-file_not_found_action_dialog.patch (3.2 KB) - added by sphery <mtdean@…> 13 years ago.

Download all attachments as: .zip

Change History (5)

Changed 13 years ago by sphery <mtdean@…>

comment:1 Changed 13 years ago by sphery <mtdean@…>

BTW, the patch is for SVN head, but the issue exists in both 0.19 and head. I can make a patch for 0_19-fixes once the patch is accepted.

comment:2 Changed 13 years ago by cpinkham

Owner: changed from Isaac Richards to cpinkham

comment:3 Changed 13 years ago by cpinkham

Resolution: fixed
Status: newclosed

(In [9490]) Fix some discrepancies in the Watch Recordings screen related to how we handle recordings where the file is not found. If the file is not found, the only actions the user can perform on the recording are to view the program details or delete the database entry.

Closes #1480 by applying patch by Michael T. Dean.

comment:4 Changed 13 years ago by cpinkham

(In [10505]) Fix some discrepancies in the Watch Recordings screen related to how we handle recordings where the file is not found. If the file is not found, the only actions the user can perform on the recording are to view the program details or delete the database entry.

Carries over Michael T. Dean's patch in [9490] from trunk.

References #1480.

Note: See TracTickets for help on using tickets.