Opened 18 years ago

Closed 18 years ago

Last modified 18 years ago

#1521 closed defect (fixed)

Video Scan type OSD improvements

Reported by: david.asher@… Owned by: danielk
Priority: minor Milestone: unknown
Component: mythtv Version:
Severity: low Keywords:
Cc: Ticket locked: no

Description

The new OSD menu entry "Video Scan" has an entry for "Detect", but because NVP::GetScanType? only returns the current scan type "Detect" is never pre-selected so it looks like we're not in autodetect mode when we are. This patch fixes that.

It also, however, removes the only indication currently available for what the current autodetected scan type is. I'm thinking of adding that to the status popup as a separate patch.

Attachments (1)

scan_menu_patch.txt​ (3.6 KB) - added by anonymous 18 years ago.

Download all attachments as: .zip

Change History (4)

comment:1 Changed 18 years ago by david.asher@…

Priority: trivial → minor
Summary: NVP::GetScanType never returns kScan_Detect → Video Scan type OSD improvements

updated patch to include the OSD improvments. The patch contains the following:

  1. Fix NVP::GetScanType?() and NVP::NextScanType?() to look at m_scan_locked to determine whether we're really in kScan_Detect instead of what m_scan says.
  1. When NEXTSCAN key is pressed popup a message saying which scan type we just cycled to.
  1. Add " (Progressive)" or " (Interlaced)" to PlayMesg? in tv_play.cpp. Required adding NVP::GetCurrentScanType?()
  1. Made the code for building the OSD Menu use the FrameScanType? enum (I kept getting confused which number was which).

Changed 18 years ago by anonymous

Attachment: scan_menu_patch.txt​ added

comment:2 Changed 18 years ago by danielk

Resolution: → fixed
Status: new → closed

(In [9423]) Closes #1521, by applying modified patch.

This shows the user they are in autodetect mode when they are, rather than showing the detected scan type. This also adds a short "I", "P" indication after the "Detect" mode string to indicate what the detected mode is.

comment:3 Changed 18 years ago by danielk

(In [9424]) References #1521, missing change in [9423].

Note: See TracTickets for help on using tickets.