Opened 14 years ago

Closed 13 years ago

Last modified 13 years ago

#1544 closed enhancement (fixed)

DVD Bookmarks for internal dvd player

Reported by: skamithi@… Owned by: skamithi
Priority: minor Milestone: 0.21
Component: mythtv Version:
Severity: low Keywords:
Cc: Ticket locked: no

Description

Two patches included. One for the mythtv trunk and the other for mythplugin trunk

Features:

  • Saves and clears bookmarks on DVDs just like a recorded show.
  • When exiting a dvd, it uses the "Action on playback exit" setting.
  • deletes old bookmarks after certain number of days. Configurable in

DVD Settings.

New table is needed to store dvd bookmarks.

CREATE TABLE `dvdbookmark` (
  `serialid` varchar(16) NOT NULL default '',
  `name` varchar(32) default NULL,
  `title` smallint(6) NOT NULL default '0',
  `part` smallint(6) NOT NULL default '0',
  `frame` bigint(20) NOT NULL default '0',
  `timestamp` timestamp NOT NULL default CURRENT_TIMESTAMP on update CURRENT_TIMESTAMP,
  PRIMARY KEY  (`serialid`)
)

Restrictions:

  • if the current title is less then 5 minutes, or in dvd menu or in a still frame,

it will not be bookmarked. Prevents you from bookmarking trailers and short clips before the feature starts.

Need Help with:

  • popup window option to ask you if you wish to play from the

start of the DVD or play from bookmark

  • add dvdbookmark table to the mythtv database schema.

Attachments (4)

mythdvd_bookmark_v1.patch (17.1 KB) - added by skamithi@… 14 years ago.
v1 patch. mythtv trunk patch.
mythdvd_bookmark2_v1.patch (952 bytes) - added by skamithi@… 14 years ago.
v1 patch mythplugin trunk.
mythdvd_bookmark_v2.patch (10.9 KB) - added by skamithi@… 14 years ago.
v2 mythtv trunk patch for dvd bookmarks.
bookmark_fix1.diff (1.6 KB) - added by skamithi 13 years ago.
watching da vinci code, it saved the current subtitle even though it should have been set to -1. this should ensure it saves the correct subtitle setting.

Download all attachments as: .zip

Change History (15)

Changed 14 years ago by skamithi@…

Attachment: mythdvd_bookmark_v1.patch added

v1 patch. mythtv trunk patch.

Changed 14 years ago by skamithi@…

Attachment: mythdvd_bookmark2_v1.patch added

v1 patch mythplugin trunk.

comment:1 Changed 14 years ago by skamithi@…

got a suggestion to expand bookmark table to include subtitle and audio track info as well, since the user may change it from the default setting. Then attempt to set the bookmarked subtitle and audio track info when activating the bookmark. looking into the issue.

found some bugs as well.

v2 of the patch will include fixes plus the suggested changes. any more feedback is most welcome.

comment:2 Changed 14 years ago by anonymous

Severity: mediumlow

Changed 14 years ago by skamithi@…

Attachment: mythdvd_bookmark_v2.patch added

v2 mythtv trunk patch for dvd bookmarks.

comment:3 Changed 14 years ago by skamithi@…

here is the current table I use. bookmarking for all different types of recordings will be integrated , so this patch and table is just to show what factors to consider for dvd bookmarks when the integration is done.

DROP TABLE IF EXISTS `dvdbookmark`;
CREATE TABLE `dvdbookmark` (
  `serialid` varchar(16) NOT NULL default '',
  `name` varchar(32) default NULL,
  `title` smallint(6) NOT NULL default '0',
  `audionum` tinyint(4) NOT NULL default '-1',
  `subtitlenum` tinyint(4) NOT NULL default '-1',
  `framenum` bigint(20) NOT NULL default '0',
  `timestamp` timestamp NOT NULL default CURRENT_TIMESTAMP,
  PRIMARY KEY  (`serialid`);

comment:4 Changed 13 years ago by Isaac Richards

Owner: changed from Isaac Richards to skamithi

comment:5 Changed 13 years ago by stuartm

Milestone: 0.21

comment:6 Changed 13 years ago by skamithi

(In [11776]) Refs #1544. DVD bookmark support. doesn't work if dvd is in a VIDEO_TS directory, due to a bug in dvd_read_name() in libdvdnav. i am not interested in fixing this because all my dvds are in the iso format. support is disabled by default (for now). go to the DVD Settings to turn it on. used for about 9 months now, works for most dvds, i've watched.

comment:7 Changed 13 years ago by skamithi

Status: newassigned

spoke to stuartm. long term, the sql calls will change when the unified bookmarking system is completed.

features included in dvd support a) deletion of "old" bookmarks. you can set how long dvd bookmarks should be retained b) while the bug in libdvdnav exists, any dvd loaded from a VIDEO_TS directory will not have a bookmark. c) you can enable a prompt if you want mythtv to ask you if u'd like to start from the beginning or start from the bookmark. d) bookmark stores subtitle and audio track at the time the bookmark was made.

comment:8 Changed 13 years ago by skamithi

(In [11777]) Refs #1544. fix dvdbookmark table creation statement. remove version specific attributes that i didn't remove when creating the statement.

comment:9 Changed 13 years ago by cpinkham

(In [11778]) Make [11777] compatible with MySQL 3.x. Refs #1544.

comment:10 Changed 13 years ago by skamithi

Resolution: fixed
Status: assignedclosed

Changed 13 years ago by skamithi

Attachment: bookmark_fix1.diff added

watching da vinci code, it saved the current subtitle even though it should have been set to -1. this should ensure it saves the correct subtitle setting.

comment:11 Changed 13 years ago by skamithi

(In [12318]) Refs #1544. dvd bookmark support. get the current track number from the dvd instead of from the NVP subtitle list when setting a dvd bookmark. fixes a minor bug.

Note: See TracTickets for help on using tickets.