Opened 14 years ago

Closed 14 years ago

#1572 closed defect (invalid)

MacOS X PowerPC not using vectorized yuv420 conversion

Reported by: mythtv@… Owned by: mythtv@…
Priority: minor Milestone: 0.20
Component: mythtv Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Looking at the Shark results when watching live tv on a PowerPC running MacOS X shows that the Altivec code for YUV420 to YUV422 conversion code is not being used. I traced it down to videoout_quartz.cpp missing a #include "config.h". Basically Altivec support is never being compiled in videoout_quartz.

Change History (2)

comment:1 Changed 14 years ago by Nigel

Owner: changed from Isaac Richards to mythtv@…

Mino, I'm not sure about this. I don't disbelieve your Shark observations, but:

  1. videoout_quartz.cpp doesn't actually use any CONFIG_* or HAVE_* that would enable/disable AltiVec?


  1. It includes yuv2rgb.h, which defines the same functions regardless of config.h


  1. The header mythconfig.h, which is the same as config.h, is included before the first thing that uses CONFIG_*


  1. Apart from the user preference in videoout_quartz.cpp which can turn it off, the file yuv2rgb.cpp is really what determines acceleration


If you have a patch (or gcc -E output or something), please attach

comment:2 Changed 14 years ago by mythtv@…

Resolution: invalid
Status: newclosed

Oops, you're right. It was added by my MacOS X Intel patch. Sorry.

This will bring up the question on how to handle compiling for both MacOS X Intel and PowerPC but that is a topic for another day.

Changing to resolved as invalid.

Note: See TracTickets for help on using tickets.