Modify

Opened 12 years ago

Closed 12 years ago

#1605 closed patch (fixed)

backend filetransfer sockets unstable when connection goes away unexpectedly

Reported by: jwestfall@… Owned by: ijr
Priority: minor Milestone: unknown
Component: mythtv Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Hi

To reproduce the issue start a commflag then ctrl-c it. The backend likes to crash.

patch does the follow

  • add UpRef/DownRef? functions to FileTransfer? class
  • convert MainServer::endConnection to use the UpRef/DownRef? functions, its not safe to delete the socket or the associated FileTransfer? object in this function.
  • add some additional checking in functions that use QSocketDevice::writeBlock, its possible for the socket to close by it never returns an error.

Attachments (2)

socket.diff (5.2 KB) - added by jwestfall@… 12 years ago.
socket1.diff (5.2 KB) - added by jwestfall@… 12 years ago.
updated to fix bug

Download all attachments as: .zip

Change History (3)

Changed 12 years ago by jwestfall@…

Changed 12 years ago by jwestfall@…

updated to fix bug

comment:1 Changed 12 years ago by ijr

  • Resolution set to fixed
  • Status changed from new to closed

(In [10037]) Patch to fix instability with file transfers from the backend when the connection drops. Will be superceeded by Jim's MythSocket? conversion patch, but that's still needs a tiny bit more work. Might as well get this in until then.

Closes #1605.

Add Comment

Modify Ticket

Action
as closed The owner will remain ijr.
The resolution will be deleted. Next status will be 'new'.
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.