Opened 12 years ago

Closed 8 years ago

Last modified 8 years ago

#1607 closed patch (wontfix)

mtd cleanup / autocrop prep.

Reported by: mcheely@… Owned by: awithers
Priority: minor Milestone: unknown
Component: mythvideo Version: head
Severity: low Keywords:
Cc: Ticket locked: no


This patch cleans up the mtd a little bit. Transcode parameters and DVD characteristics are now member variables of DVDTranscodeThread. buildTranscodeCommandLine() doesn't end up querying the database twice in two-pass mode (or at all). GetTranscodeParams?() queries the database once early in DVDTranscodeThread::run().

Transcode parameters can now be changed in the middle of a job for things like autocropping, and will be persistant across runs in two-pass encoding. Also, buildTranscodeCommandLine() is called in the same place for both passes, making the code ever so slightly less confusing.

Attachments (1)

mtd_cleanup.patch (10.1 KB) - added by mcheely@… 12 years ago.

Download all attachments as: .zip

Change History (11)

Changed 12 years ago by mcheely@…

comment:1 Changed 12 years ago by mcheely@…

  • Owner changed from ijr to awithers

I always forget something

comment:2 Changed 12 years ago by awithers

  • Milestone set to 0.21

comment:3 Changed 11 years ago by awithers

  • Component changed from mythdvd to mythvideo

comment:4 Changed 10 years ago by awithers

  • Milestone changed from 0.21 to 0.22

comment:5 Changed 10 years ago by danielk

  • Version set to head

comment:6 Changed 9 years ago by Dibblah

  • Status changed from new to infoneeded_new

This patch no longer applies to trunk, even when taking into account that mythdvd is now mythvideo. Is this still required?

comment:7 Changed 9 years ago by awithers

  • Status changed from infoneeded_new to new

comment:8 Changed 9 years ago by laga

  • Milestone changed from 0.22 to 0.23

Postponing to 0.23.

comment:9 Changed 8 years ago by robertm

  • Resolution set to wontfix
  • Status changed from new to closed

This ticket is ancient, patch hasn't applied in a long, long time, we can open a task ticket if we want to do this kind of thing later.

comment:10 Changed 8 years ago by stuartm

  • Milestone changed from 0.23 to unknown

Add Comment

Modify Ticket

as closed The owner will remain awithers.
The resolution will be deleted. Next status will be 'new'.

E-mail address and user name can be saved in the Preferences.

Note: See TracTickets for help on using tickets.