Opened 13 years ago

Closed 13 years ago

#1636 closed defect (fixed)

MythWeb In IE shows red-cross/missing image icon on most images

Reported by: ciaran+mythtv@… Owned by: xris
Priority: trivial Milestone: 0.20
Component: mythweb Version: head
Severity: low Keywords:
Cc: ciaranj+mythtv@… Ticket locked: no

Description

Only a minor fault really, but on my setup (Apache does multiple things so Mythweb isn't aliased to root) the alpha blending behaviour that expects an absolute path to have mythweb as the root falls over and causes the images to display incorrectly [that ubiquitous red-cross appears].

Please find attached a small patch that fixes that (at least for me!) and also slightly changes the CSS on the welcome page to make the display a little more pleasant in IE. (specifcally states the height of the box to 30em, rather than just setting the min-height to 30em, could cause problems in the future however if modules overflow? )

Note this patch also partially fixes ticket #1317, I didn't do the complete fix because it appears to be a world of pain, existing code relies on border-color: transparent; but good ol' IE doesn't support this standard CSS ;). The best work-around I could find involves Javascript and was a larger change than I have time to do right now, sorry.

ciao.

  • Ciaran

Attachments (2)

minorIEFixes.diff (1.3 KB) - added by ciaranj+mythtv@… 13 years ago.
Diff of changes
minorIEFixes.2.diff (1.3 KB) - added by ciaranj+mythtv@… 13 years ago.
Should-be-relative patch.

Download all attachments as: .zip

Change History (7)

Changed 13 years ago by ciaranj+mythtv@…

Attachment: minorIEFixes.diff added

Diff of changes

Changed 13 years ago by ciaranj+mythtv@…

Attachment: minorIEFixes.2.diff added

Should-be-relative patch.

comment:1 Changed 13 years ago by xris

fyi, please read the FAQ in the README from the fixes branch... This is unfortunately a "fix it yourself" kind of thing if you install mythweb outside of the document root. Relative URL won't work on anything other than the main page because of now I set up mod_rewrite.

Will look into the other parts of the patch later.

comment:2 Changed 13 years ago by anonymous

I'm confused, it seems to work for me on all of the pages/sub-pages. Sorry for my misunderstanding :( Also, I've just been into http://cvs.mythtv.org/trac/browser/branches/release-0-19-fixes/mythplugins/mythweb/README?rev=9625

and I can't follow the part you're pointing me to, is there a different fixes branch that I should be looking at (again sorry!) .

Just FYI, my installation is *within* document root, it is a subfolder ie. /var/www/html/mythweb -[symlink]-> svn source of mythweb.

comment:3 Changed 13 years ago by anonymous

Cc: ciaranj+mythtv@… added

just adding myself to Cc list.

comment:4 Changed 13 years ago by xris

From the MythWeb README:

Q: Why do a bunch of the images have little X's over them when using IE?

A: The hack used to make IE display transparent PNG's relies on a hard-coded

image address in js/pngbehavior.htc. If your MythWeb installation is anywhere other than the root directory, the default won't work and you will have to hand-edit the file with the correct path. Look for the line that contains "/skins/default/img/spacer.gif" -- usually adding a /mythweb at the start of the string will solve your problem.

... To the other people in this ticket, it won't work as a relative path because if you are at /mythweb/tv/list, the relative path would then point to /mythweb/tv/skins/default... and there is no such icon at that path because mythweb.php sees the "tv" and passes it off to the tv module handler.

comment:5 Changed 13 years ago by xris

Resolution: fixed
Status: newclosed

(In [9631]) Apply parts of the css patch to close #1636

Note: See TracTickets for help on using tickets.