Opened 18 years ago
Closed 18 years ago
#1656 closed patch (fixed)
mythfilldatabase has problems with crappy canadian listings
| Reported by: | Owned by: | cpinkham | |
|---|---|---|---|
| Priority: | minor | Milestone: | unknown |
| Component: | mythtv | Version: | |
| Severity: | medium | Keywords: | |
| Cc: | Ticket locked: | no |
Description
Up here in the Great White North, some 40% of the channels stop their listings at 8pm on day 12. Unfortunately, that still leaves enough data so that mythfilldatabase thinks all is ok. The attached patch adds another test with counts the number of channels with programs starting between 8pm and midnight, and triggers a refetch if that does not match the number of channels. It also makes the thresholds for the existing tests configurable from the command line, though I could not get the results I wanted by tuning them, someone may find it usefull.
Attachments (2)
Change History (8)
Changed 18 years ago by
| Attachment: | canda.patch added |
|---|
Changed 18 years ago by
| Attachment: | canda.2.patch added |
|---|
comment:1 Changed 18 years ago by
| Owner: | changed from Isaac Richards to cpinkham |
|---|
comment:2 Changed 18 years ago by
| Type: | enhancement → patch |
|---|
comment:3 Changed 18 years ago by
Is this patch really needed? I have the same problem but I just run mythfilldatabase with a "--max-days 11" argument.
comment:4 Changed 18 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
(In [11180]) Add another check criteria that will force mythfilldatabase to download data for a particular day. If the number of channels with at least one program between 6pm and midnight is less than 90% of the count for the previous day, a data refresh will be initiated. This catches cases where some channels may have all data for a given day, but others may have none, but there is still enough data to pass the (chanCount * 4) test.
Closes #1656 by applying my own version of the above mentioned logic. I don't think the rest of the patch is necessary.
comment:5 Changed 18 years ago by
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
Close, but no cigar. The channels in question have data up until 8pm, so a start time 6pm make the extra checking useless. I changed the start time to 8pm, and changed the programs per channel to 3 from 4 to avoid unnecessary updates, and it looks like it's working ok.
comment:6 Changed 18 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
(In [11393]) Tweak a couple settings in mythfilldatabase when determining whether to retrieve data for a specific day offset based on how much show info is available for the last hours of the day. Instead of the last 6 hours, just check the last 4 and change the number of required programs from 4 to 3.
This is based on analysis of my own zap2it data which usually ends around 8pm on the last day along with several reports from other users including #1656 (ticket #1656, not user #1656).
Re-closes #1656.
The correct patch