Opened 14 years ago

Closed 14 years ago

#1656 closed patch (fixed)

mythfilldatabase has problems with crappy canadian listings

Reported by: ajlill@… Owned by: cpinkham
Priority: minor Milestone: unknown
Component: mythtv Version:
Severity: medium Keywords:
Cc: Ticket locked: no

Description

Up here in the Great White North, some 40% of the channels stop their listings at 8pm on day 12. Unfortunately, that still leaves enough data so that mythfilldatabase thinks all is ok. The attached patch adds another test with counts the number of channels with programs starting between 8pm and midnight, and triggers a refetch if that does not match the number of channels. It also makes the thresholds for the existing tests configurable from the command line, though I could not get the results I wanted by tuning them, someone may find it usefull.

Attachments (2)

canda.patch (984 bytes) - added by ajlill@… 14 years ago.
canda.2.patch (10.6 KB) - added by ajlill@… 14 years ago.
The correct patch

Download all attachments as: .zip

Change History (8)

Changed 14 years ago by ajlill@…

Attachment: canda.patch added

Changed 14 years ago by ajlill@…

Attachment: canda.2.patch added

The correct patch

comment:1 Changed 14 years ago by cpinkham

Owner: changed from Isaac Richards to cpinkham

comment:2 Changed 14 years ago by cpinkham

Type: enhancementpatch

comment:3 Changed 14 years ago by greg

Is this patch really needed? I have the same problem but I just run mythfilldatabase with a "--max-days 11" argument.

comment:4 Changed 14 years ago by cpinkham

Resolution: fixed
Status: newclosed

(In [11180]) Add another check criteria that will force mythfilldatabase to download data for a particular day. If the number of channels with at least one program between 6pm and midnight is less than 90% of the count for the previous day, a data refresh will be initiated. This catches cases where some channels may have all data for a given day, but others may have none, but there is still enough data to pass the (chanCount * 4) test.

Closes #1656 by applying my own version of the above mentioned logic. I don't think the rest of the patch is necessary.

comment:5 Changed 14 years ago by ajlill@…

Resolution: fixed
Status: closedreopened

Close, but no cigar. The channels in question have data up until 8pm, so a start time 6pm make the extra checking useless. I changed the start time to 8pm, and changed the programs per channel to 3 from 4 to avoid unnecessary updates, and it looks like it's working ok.

comment:6 Changed 14 years ago by cpinkham

Resolution: fixed
Status: reopenedclosed

(In [11393]) Tweak a couple settings in mythfilldatabase when determining whether to retrieve data for a specific day offset based on how much show info is available for the last hours of the day. Instead of the last 6 hours, just check the last 4 and change the number of required programs from 4 to 3.

This is based on analysis of my own zap2it data which usually ends around 8pm on the last day along with several reports from other users including #1656 (ticket #1656, not user #1656).

Re-closes #1656.

Note: See TracTickets for help on using tickets.