Opened 13 years ago

Closed 13 years ago

#1675 closed defect (worksforme)

Recgroup Default saved translated instead of untranslated

Reported by: Oscar Carlsson Owned by: cpinkham
Priority: minor Milestone: 0.20
Component: mythtv Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

When selecting the default recording group in the recording settings, ManagedListItem::getValue() returns the translation for "Default" instead of the untranslated string, which results in all sorts of oddness.

One possible solution would be something like this:

        virtual const QString& getValue() const
        {
            if (valueText == tr("Default"))
                return "Default";

            return valueText;
        }

but I'm not sure what else would be affected by that. Another solution would be to class SRRecGroup (and others) store the display value and the real value seperately.

Fixing this should also include fixing the database, searching record and records for tr("Default").

Change History (2)

comment:1 Changed 13 years ago by cpinkham

Owner: changed from Oscar Carlsson to cpinkham

The code for SRRecGroup appears correct, it should be displaying the translated value for display and the English "Default" as the settingValue. It does get the list from the record and recorded tables though, so this may be feeeding on itself. Can you update your recgroup field in both the record and recorded tables to have the English translation for 'Default' and then see if the bug still occurs when you add a new scheduled recording?

comment:2 Changed 13 years ago by cpinkham

Resolution: worksforme
Status: newclosed

Seems to work fine here. I tried to replicate by setting my language to Spanish and creating a new scheduled recording. The text on screen said 'Por defecto' and was saved properly to the record table as 'Default'. Closing ticket for now, it can be repopened if someone can replicate the issue. I'm assuming this was fixed along the way or there was a translated version of 'Default' in the DB which was feeding bad data to the select list.

Note: See TracTickets for help on using tickets.