Opened 18 years ago
Closed 18 years ago
#1682 closed patch (fixed)
cleanup subtitles on channel change
| Reported by: | Owned by: | danielk | |
|---|---|---|---|
| Priority: | minor | Milestone: | unknown |
| Component: | mythtv | Version: | 0.19 |
| Severity: | medium | Keywords: | |
| Cc: | Ticket locked: | no |
Description
DVB subtitles are not cleared in channel change. This results in the last visible subtitle staying until its expired when changed to a new channel without subtitles. This trivial patch seems to fix the problem.
It's against 0.19-fixes, but is straightforward to apply to HEAD too.
Attachments (3)
Change History (9)
Changed 18 years ago by
| Attachment: | cleanup_subtitles_on_channel_change.diff added |
|---|
comment:1 Changed 18 years ago by
| Resolution: | → invalid |
|---|---|
| Status: | new → closed |
Changed 18 years ago by
| Attachment: | cleanup_subtitles_on_channel_change-proper.diff added |
|---|
Proper patch, as instructed by Isaac.
comment:2 Changed 18 years ago by
| Resolution: | invalid |
|---|---|
| Status: | closed → reopened |
This patch should do the cleanup in proper places, as instructed by Isaac on thread http://www.gossamer-threads.com/lists/mythtv/dev/198127
Please apply both to 0.19 and 0.20.
comment:3 Changed 18 years ago by
(In [9733]) References #1682, clears dvb subtitles on livetv ringbuffer changes.
The patch was not thread-safe, but just added the ClearSubtitles?() code in the relevant places.
If there are no bugs reported with this in the next couple weeks I'll apply it to 0.19-fixes.
comment:4 Changed 18 years ago by
| Version: | → 0.19 |
|---|
comment:5 Changed 18 years ago by
(In [9805]) Closes #1736. Refs #1682. Fixes autoselection of subtitle/caption streams when the streams are not immediately available.
Caption streams are often not detected until a few seconds into playback. This means the autoselect was usually selecting Teletext 888 or CC-1 captions rather than the more desirable options, such as a caption stream in one of your preferred languages.
This references #1682 only because I accidentally placed a version of the patch there.
This patch will clear the subtitles on any resolution or aspect ratio change, not just on channel changes. Can you try to make this more specific to channel changes? I'm not sure this will even clear the subtitles when the resolution and aspect ratio don't change on a channel change.