Opened 13 years ago

Closed 13 years ago

#1688 closed defect (fixed)

Finnish DVB EIT languages and subtitle/description field

Reported by: otto at kolsi dot fi Owned by: danielk
Priority: minor Milestone: 0.20
Component: dvb Version: head
Severity: medium Keywords: DVB, EIT
Cc: Ticket locked: no

Description

With SVN 9710, Swedish DVB EIT info is inserted into DB instead of Finnish (although in settings there is 'fin' as a primary language). This is happening in Finland where the EIT info contains data for both languages.

Also, it seems that description data is now inserted into the subtitle field.

I've attached backend log with "eit,siparser" options. This includes first EIT update round after backend restart.

Attachments (1)

eit_log.txt (47.5 KB) - added by otto at kolsi dot fi 13 years ago.
eit, siparser backend log

Download all attachments as: .zip

Change History (6)

Changed 13 years ago by otto at kolsi dot fi

Attachment: eit_log.txt added

eit, siparser backend log

comment:1 Changed 13 years ago by danielk

Milestone: 0.20

Are you capable of debugging? If so the code for the language selection is in libs/libmythtv/mpeg/mpegdescriptors.cpp

There are two methods FindBestMatch?() and FindBestMatches?() for the title and description, respectively.

langPrefs is a list of the canonical language keys, for "fin" the key would be 6711662 and for 'swe' the key would be 7567205. For each key there is a priority. In your case 'fin' should have priority 1 and 'swe' should have priority 2.

The intent of these methods is to pick out the descriptor[s] in the language with the highest priority. If you can figure out why it isn't doing this we can fix the problem.

If you can't debug this I can send you a series of patches to try, but that is a slow and difficult process.

If you have questions, please air them in mythtv-dev.

comment:2 Changed 13 years ago by danielk

(In [9763]) refs #1035, refs #1688. Preferred language fix for DVB EIT.

comment:3 Changed 13 years ago by danielk

(In [9767]) Refs #1035, refs #1688. Always do some basic fixups with DVB EIT.

comment:4 Changed 13 years ago by danielk

(In [9773]) refs #1688, closes #1712. Fixes sentinel checks for language selections in DVB EIT tables.

The sentinels were changed for #1688 in [9763], because the language preferences were reversed, but I missed the later checks on these sentinels, so if the descriptor was missing completely bogus data was returned.

comment:5 Changed 13 years ago by danielk

Resolution: fixed
Status: newclosed

Otto reported this as fixed in mailing list.

Note: See TracTickets for help on using tickets.