Opened 13 years ago
Closed 13 years ago
#1748 closed patch (fixed)
External text-based subtitle file support for the internal video player
| Reported by: | Owned by: | danielk | |
|---|---|---|---|
| Priority: | minor | Milestone: | 0.20 |
| Component: | mythtv | Version: | head |
| Severity: | medium | Keywords: | external subtitle files |
| Cc: | Ticket locked: | no |
Description
Adds text-based subtitle support to the internal video player.
Such subtitles are provided in external files with extensions like '.srt', '.txt', or '.sub'. The implementation uses a parser taken from Xine to read in the subtitles.
Following formats are supported by the parser: MicroDVD, SubRip?, SubViewer?, SAMI, VPlayer, RT, Sub Station Alpha, PJS, MPSUB, AQTitle, JacobSub?, Subviewer2, Subrip09, and Mplayer sub 2.
Attachments (7)
Change History (15)
Changed 13 years ago by
| Attachment: | external_text_subtitle_file_support.diff added |
|---|
comment:1 Changed 13 years ago by
| Owner: | changed from Isaac Richards to danielk |
|---|
Changed 13 years ago by
| Attachment: | external_text_subtitle_file_support.v2.diff added |
|---|
patch against trunk, removed usage of my debugging header debug.h
comment:2 Changed 13 years ago by
| Resolution: | → invalid |
|---|---|
| Status: | new → closed |
Pekka, a few problems:
- TABs are bad.
- Please use the same bracketing as the rest of MythTV.
- QStrings are not thread safe, use a mutex and qdeepcopy when allowing more than one thread to access a string.
- make all get methods const methods.
- using a linear search for the current subtitle will not deal with seeking all that well. Using the STL binary search find would be pretty easy.
- passing iterators around is kind of scary, these can be invalidated by a change to the underlying structure. If you reload the subtitles you can easilly get a segfault.
- osd.cpp has the patch in #1515 applied; please remove this.
Please reopen the ticket when the patch is ready.
Changed 13 years ago by
| Attachment: | external_text_subtitle_file_support.v3.patch added |
|---|
fixed the issues danielk pointed out
comment:3 Changed 13 years ago by
| Resolution: | invalid |
|---|---|
| Status: | closed → reopened |
comment:4 Changed 13 years ago by
The attached version fixes a bug occuring on some Qt versions. Some Qt versions do not accept full paths in the search string when querying directory contents, so the directory had to be given separately or no entries were found.
Thanks for raptorjr for tracking this out.
Changed 13 years ago by
| Attachment: | external_text_subtitle_file_support.v5.patch added |
|---|
added #include <stdint.h> to subtitleparser.h
Changed 13 years ago by
| Attachment: | external_text_subtitle_file_support.v5.2.patch added |
|---|
added #include <stdint.h> to subtitleparser.h
comment:5 Changed 13 years ago by
The uploaded patches (v5, v5.2) are equal, it just got uploaded twice due to a refresh I did because of a database locked error.
comment:6 Changed 13 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
(In [10067]) Fixes #1748. Adds external subtitle file support for internal video player.
This is basically MythTV glue to the xine support for external subtitles, so any subtitle supported by xine should now be supported by MythTV. The subtitles are only loaded if they have the same base name as the video file, and end with one of the standard subtitle extensions.
comment:7 Changed 13 years ago by
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
| Type: | patch → enhancement |
(hope this is the right place...)When subtitles in the file are in UTF-8, with some accents or other characters(ñ,Ñ,¿,¡,... spanish charset mainly), strange symbols are displayed on screen. Maybe I can help on solvind this issue, if some help on where to start looking is given (fontname? QString issues?... Sorry, no much knowledge about myth coding). Thanks.
comment:8 Changed 13 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
| Type: | enhancement → patch |
Open new tickets for new issues.
patch against trunk