Opened 14 years ago

Closed 14 years ago

#1768 closed patch (fixed)

Fix off by one error in assembly of PSIP

Reported by: anonymous Owned by: danielk
Priority: minor Milestone: unknown
Component: dvb Version:
Severity: medium Keywords:
Cc: Ticket locked: no

Description

attached patch fixes an of by one error in assembly of PSIP from ts packets. It is only triggered if the PSIP ends at the end of one tspacket.

I see that bug only after the removal of the sectionreader in DVBSiparser in [9816].

Is there a reason why the real data starts at PSIOffset()+1? I think I remember it makes sense if you look at the mpeg standard. But it confuses me everytime I look at it. So we should at least add a big red blinking comment stating the reason.

Attachments (1)

assemble_psip_off_by_one_error.diff (714 bytes) - added by Janne <janne-mythtv@…> 14 years ago.

Download all attachments as: .zip

Change History (2)

Changed 14 years ago by Janne <janne-mythtv@…>

comment:1 Changed 14 years ago by danielk

Resolution: fixed
Status: newclosed

(In [9857]) Closes #1768. Applies Janne's patch for off by one error in PSIP assembly against mythtv-eit branch.

We believe the +1 is needed due to the one byte allocated for to the pointer field in payload start packets.

Note: See TracTickets for help on using tickets.