Opened 18 years ago
Closed 18 years ago
#1800 closed patch (fixed)
dvbstreamdata::SetVersionEIT broken
Reported by: | Stuart Auchterlonie | Owned by: | danielk |
---|---|---|---|
Priority: | minor | Milestone: | 0.20 |
Component: | dvb | Version: | head |
Severity: | medium | Keywords: | dvb eit |
Cc: | Ticket locked: | no |
Description
dvbstreamdata.h::SetVersionEIT was not setting _eit_version at all. This patch corrects this problem. Cures a lot of errors I was seeing in valgrind as well.
Attachments (1)
Change History (4)
Changed 18 years ago by
Attachment: | set-eit-version.diff added |
---|
comment:1 Changed 18 years ago by
Stuart, I thought you didn't want DVBStreamData to ignore the EIT's we have already seen and wanted use the event cache instead.
If you are sure you want this I'll apply the patch..
comment:2 Changed 18 years ago by
Daniel,
This is more about the correctness of the table section tracking. We use SetVersionEIT to track the current version of the table we are looking at in dvbstreamdata::HandleTables?() and then checked in IsRedundant?()
Without this we would never see redundant tables, and thus it causes a lot of unneeded processing. This does fix a regression compared to when the EventCache? was first implemented.
I recommend the patch be applied.
Correct SetVersionEIT()