Opened 13 years ago

Closed 13 years ago

#1800 closed patch (fixed)

dvbstreamdata::SetVersionEIT broken

Reported by: Stuart Auchterlonie Owned by: danielk
Priority: minor Milestone: 0.20
Component: dvb Version: head
Severity: medium Keywords: dvb eit
Cc: Ticket locked: no

Description

dvbstreamdata.h::SetVersionEIT was not setting _eit_version at all. This patch corrects this problem. Cures a lot of errors I was seeing in valgrind as well.

Attachments (1)

set-eit-version.diff (618 bytes) - added by Stuart Auchterlonie 13 years ago.
Correct SetVersionEIT()

Download all attachments as: .zip

Change History (4)

Changed 13 years ago by Stuart Auchterlonie

Attachment: set-eit-version.diff added

Correct SetVersionEIT()

comment:1 Changed 13 years ago by danielk

Stuart, I thought you didn't want DVBStreamData to ignore the EIT's we have already seen and wanted use the event cache instead.

If you are sure you want this I'll apply the patch..

comment:2 Changed 13 years ago by Stuart Auchterlonie

Daniel,

This is more about the correctness of the table section tracking. We use SetVersionEIT to track the current version of the table we are looking at in dvbstreamdata::HandleTables?() and then checked in IsRedundant?()

Without this we would never see redundant tables, and thus it causes a lot of unneeded processing. This does fix a regression compared to when the EventCache? was first implemented.

I recommend the patch be applied.

comment:3 Changed 13 years ago by danielk

Resolution: fixed
Status: newclosed

This was accidentally committed in [9961].

Note: See TracTickets for help on using tickets.