Opened 14 years ago

Closed 14 years ago

Last modified 14 years ago

#1831 closed defect (wontfix)

mythfilldatabase broken for xmltvid containing spaces

Reported by: urnest@… Owned by: Isaac Richards
Priority: minor Milestone: unknown
Component: mythtv Version:
Severity: medium Keywords:
Cc: Ticket locked: no

Description

mythfilldatabase, with xml_tv_grab only uses part of the channel id, up to the first space. e.g. xmltv data entry with

<programme channel="TEN Digital" start="20060520130000 +0000" stop="20060520150000 +0000">

... gives a messages:

 Unknown xmltv channel identifier: TEN
Skipping channel.

... with 'TEN' rather than 'TEN Digital'. It also puts in a new channel, which is probably another bug?:

mysql> select name, chanid, xmltvid from channel where name = 'TEN DIGITAL'; 
    :
| TEN Digital |   1007 | TEN Digital |
| TEN Digital |      4 | TEN Digital |
    :

... I already had 1007 and I now have 4 too.

Here is the patch I use for my guide-data:

xju@xjutv ~/2/mythtv/programs/mythfilldatabase $ svn diff filldata.cpp
Index: filldata.cpp
===================================================================
--- filldata.cpp        (revision 9947)
+++ filldata.cpp        (working copy)
@@ -1318,10 +1318,10 @@
     pginfo->endts = text;

     text = element.attribute("channel", "");
-    QStringList split = QStringList::split(" ", text);
+    pginfo->channel = text;
+
+    QStringList split;

-    pginfo->channel = split[0];
-
     text = element.attribute("clumpidx", "");
     if (!text.isEmpty())
     {

Attachments (1)

xxx.xmltv (57.4 KB) - added by urnest@… 14 years ago.
complete (short) xmltv data file that triggers problem

Download all attachments as: .zip

Change History (4)

Changed 14 years ago by urnest@…

Attachment: xxx.xmltv added

complete (short) xmltv data file that triggers problem

comment:1 Changed 14 years ago by Isaac Richards

Resolution: wontfix
Status: newclosed

Will break other grabbers.

comment:2 Changed 14 years ago by Isaac Richards

Priority: majorminor

comment:3 Changed 14 years ago by mattias.holmlund@…

This problem should be fixed in the grabber. According to the xmltv dtd, the channel id cannot contain spaces. It should follow the same syntax as a dns-name.

Note: See TracTickets for help on using tickets.