Opened 14 years ago

Closed 14 years ago

#1859 closed defect (fixed)

mytharchive audio track selection fix

Reported by: anonymous Owned by: Isaac Richards
Priority: minor Milestone: unknown
Component: mythtv Version:
Severity: medium Keywords: mytharchive
Cc: Ticket locked: no

Description

Two patches for mytharchive:

  1. The wrong audio track was being selected in the "desired language not found - just pick best avail track" case. The track index variable was not being set properly.
  1. Pass the selected audio track unchanged. I have all US DVB recordings, most with 5.1 audio. The processing was converting them to ac3 mono. This patch retains the 5.1 audio. I'm not sure what it'll do with other audio inputs. YMMV.

Overall it was really nice being able to select a recording and come back later to a finished DVD.

Attachments (2)

mythburn.indexfix.diff (642 bytes) - added by anonymous 14 years ago.
mythburn.acodec.diff (646 bytes) - added by anonymous 14 years ago.

Download all attachments as: .zip

Change History (4)

Changed 14 years ago by anonymous

Attachment: mythburn.indexfix.diff added

Changed 14 years ago by anonymous

Attachment: mythburn.acodec.diff added

comment:1 Changed 14 years ago by paulh

(In [10014]) References #1859. Apply the first patch in the ticket. Fixes selecting the required audio track.

comment:2 Changed 14 years ago by paulh

Resolution: fixed
Status: newclosed

(In [10015]) Closes #1859. Fixes the second issue on the ticket - if the audio track is already in ac3 format tell ffmpeg to pass it unchanged to the output file.

It also changes the re-encoded audio track to be ac3 in stereo rather than mono that ffmpeg defaults to. Changing it to produce 5.1 seems to cause ffmpeg to seg fault for me.

Note: See TracTickets for help on using tickets.