Opened 13 years ago

Closed 13 years ago

#1874 closed patch (fixed)

MythWeb-Add never record/forget old options to detail page

Reported by: sphery <mtdean@…> Owned by: xris
Priority: minor Milestone: unknown
Component: mythweb Version:
Severity: medium Keywords:
Cc: Ticket locked: no

Description

The attached patches ( mythweb-never_record_on_detail_page* ) add the never record and forget old options to the detail page of the tv module in MythWeb. They allow you to specify a show should not be recorded even if you do not have a matching recording rule (I use it to mark movies I've seen so I don't have to remember them myself).

I'm also using the patch mythweb-recstatus_without_subtitle_and_description.patch on my system. Without it, the recstatus query is not performed for shows with neither a programid nor seriesid that are missing any of title, subtitle, or description. With DataDirect listings, that means that the recstatus query will not happen for movies (and perhaps other programs). If the recstatus query does not happen, the user will be offered the option to mark the program to never record, but will never get confirmation that the program was marked to never record. Also, since rec_never_record() uses a REPLACE INTO with NOW() for starttime and endtime, the user can easily insert multiple rows for the same program into the oldrecorded table. If the recstatus is known to be either recorded or never record, the user is not given the option to Never Record (instead only the option Forget Old).

Although the patch is simple, I couldn't decide which approach to use for the UI. The patch mythweb-never_record_on_detail_page.patch shows " (Forget Old)" after the MythTV status message in the program_details div but puts "Never Record" into the "local_links" div. The patch mythweb-never_record_on_detail_page-local_links.patch always shows either "Never Record" or "Forget Old" (as appropriate) in the same place in the local_links div.

Having "Forget Old" right after the MythTV Status message seemed very appropriate, but didn't leave a good place for "Never Record". I considered placing the "Never Record" option as another radio button under "Schedule Options", but decided against it because it applies to the program, not to the entire schedule/rule (and users could easily confuse it's purpose with canceling a recording rule). Also, I considered placing Never Record before or after the external_searches div in the program_title div, but it looked like it was part of the information about that show (i.e. that it would never record) as opposed to an option to mark it to never record.

I reused the translations from the "Upcoming Recordings" page; however the other links in "local_links" are more verbose, so if you want me to change it to use different translations, please let me know.

Attachments (3)

mythweb-never_record_on_detail_page.patch (3.1 KB) - added by sphery <mtdean@…> 13 years ago.
mythweb-never_record_on_detail_page-local_links.patch (2.6 KB) - added by sphery <mtdean@…> 13 years ago.
mythweb-recstatus_without_subtitle_and_description.patch (673 bytes) - added by sphery <mtdean@…> 13 years ago.

Download all attachments as: .zip

Change History (6)

Changed 13 years ago by sphery <mtdean@…>

Changed 13 years ago by sphery <mtdean@…>

Changed 13 years ago by sphery <mtdean@…>

comment:1 Changed 13 years ago by sphery <mtdean@…>

Component: mythtvmythweb

comment:2 Changed 13 years ago by xris

(In [11003]) apply a patch-alike to implement what the mythweb-recstatus_without_subtitle_and_description.patch does, but hopefully without any side effects for recording things like 'paid programming' or 'news'. re #1874

comment:3 Changed 13 years ago by xris

Resolution: fixed
Status: newclosed

(In [11004]) Apply portions of the 'never record/forget old' patches, but rearrange the page location of the links to something I think works a little better (until we completely redesign that page to make room for them). closes #1874

Note: See TracTickets for help on using tickets.