Opened 15 years ago

Closed 15 years ago

Last modified 15 years ago

#1877 closed enhancement (invalid)

New Commercial Flagger

Reported by: Robert Tsai <rtsai1111> Owned by: cpinkham
Priority: minor Milestone: unknown
Component: mythtv Version: head
Severity: low Keywords:
Cc: Ticket locked: no


This is a new commercial flagger framework (CommDetector2). It is intended to provide an infrastructure to make adding new analysis strategies easier to add and combine with existing strategies. The initializer registers the various analyzers, and the main loop decodes all the frames and calls each analyzer with that frame.

There is also a brand-new logo detector based on Canny edge detection, with some other building blocks that can be re-used for other strategies (BorderDetector?, PGMConverter). A full description of the logo detector can be seen at

Near-term plans:

  • Port some of the ClassicCommDetector? strategies over into CommDetector2.
  • Add globalsettings for the tunable parameters (currently "const int" in the code, commented with "TUNABLE").

Longer-term plans:

  • Provide an interactive way to tune the flagger's parameters. For example, the logo template is currently saved to the filesystem. I'd like to provide a mechanism in the "Edit Recordings" mode to overlay the template with the current frame, with some kind of OSD or something to show why (or why not) a frame was flagged as a commercial (or not).

Attachments (2)

mythtv.commflag.diff (117.1 KB) - added by Robert Tsai <rtsai1111> 15 years ago.
mythtv-commflag.diff (125.0 KB) - added by Robert Tsai 15 years ago.
some minor tweakage

Download all attachments as: .zip

Change History (6)

Changed 15 years ago by Robert Tsai <rtsai1111>

Attachment: mythtv.commflag.diff added

comment:1 Changed 15 years ago by Robert Tsai

Should mention a few things:

  • No UI yet; interested people can set "CommercialSkipMethod?" to 511.
  • Debugging mode will frames at various levels of processing into a recording-specific subdirectory of the recording directory; grep for "DebugLevel?" in mythcommflag/*.cpp

Changed 15 years ago by Robert Tsai

Attachment: mythtv-commflag.diff added

some minor tweakage

comment:2 Changed 15 years ago by Robert Tsai

Resolution: invalid
Status: newclosed

For now, work will go in to branches/commdetector2

comment:3 Changed 15 years ago by anonymous

just wondering if this new infrastructure will more easily allow adding commercial detection via audio fingerprinting?

comment:4 Changed 15 years ago by anonymous

Then why don't you ask on the mailing list?

Note: See TracTickets for help on using tickets.