Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#1900 closed defect (fixed)

Catch error condition in osd.cpp

Reported by: stuart@… Owned by: danielk
Priority: minor Milestone: 0.20
Component: mythtv Version: head
Severity: medium Keywords:
Cc: Ticket locked: no

Description

The code assumes that the number of available options in the theme will always be >= the number of menu options. The attached patch just emits a meaningful error to the console/log when this is not the case.

Attachments (2)

osd_error.patch​ (604 bytes) - added by stuart@… 13 years ago.
osd_error.2.patch​ (597 bytes) - added by stuart@… 13 years ago.
Working patch

Download all attachments as: .zip

Change History (5)

Changed 13 years ago by stuart@…

Attachment: osd_error.patch​ added

comment:1 Changed 13 years ago by danielk

Milestone: → 0.20
Owner: changed from Isaac Richards to danielk

comment:2 Changed 13 years ago by danielk

Resolution: → wontfix
Status: new → closed

Patch is malformed + I don't see the need for it...

Changed 13 years ago by stuart@…

Attachment: osd_error.2.patch​ added

Working patch

comment:3 Changed 13 years ago by danielk

Resolution: wontfix → fixed

(In [10150]) Fixes #1900. Adds a little defensive programming for 3rd party theme developers. Prints an error message if # of menu items is not supported by theme.

Note: See TracTickets for help on using tickets.