Opened 15 years ago

Closed 15 years ago

Last modified 4 weeks ago

#192 closed enhancement (fixed)

[PATCH] DBOX2 Feed Implementation 2005-08-02

Reported by: mythtv@… Owned by: taylor
Priority: trivial Milestone: unknown
Component: mythtv Version: head
Severity: high Keywords:
Cc: Ticket locked: no

Description

Hi people,

attached you will find an implementation for using the DBOX2 as a MythTV DVB source. This is an updated release for the current subversion repository. Please include it as soon as possible as it includes database schema upgrades which will become invalid as soon as we cycle to another database version.

Features:

  • using the Nokia/Sagem/Philips? DBOX2 STB with Neutrino as a video source for MythTV
  • using the Dreambox STB with Neutrino as a video source for MythTV
  • multiple DBOX2s can be used
  • grabs a complete TS stream from the DBOX2 using SPTS mode (all audio streams available in myth)
  • automatic EPG scan of all DBOX2 channels when recorder/livetv is inactive

On your DBOX2 please use a recent tuxbox version (at least 2.x) and enable SPTS mode in the configuration.

Comments welcome.

Levon

Attachments (4)

mythtv-dbox2-200508021716.patch.bz2 (5.1 KB) - added by mythtv@… 15 years ago.
[PATCH] DBOX2 Feed Implementation 2005-08-02
mythtv-dbox2-200508021716.patch.text (16.2 KB) - added by mythtv@… 15 years ago.
[mythtv] [PATCH] DBOX2 Feed Implementation 2005-08-02
mythtv-dbox2-200508022011.patch.bz2 (15.8 KB) - added by mythtv@… 15 years ago.
[mythtv] [PATCH] DBOX2 Feed Implementation 2005-08-02 (including missing files)
mythtv-dbox2-200508022011.patch.text (68.7 KB) - added by mythtv@… 15 years ago.
[mythtv] [PATCH] DBOX2 Feed Implementation 2005-08-02 (including missing files)

Download all attachments as: .zip

Change History (12)

Changed 15 years ago by mythtv@…

[PATCH] DBOX2 Feed Implementation 2005-08-02

Changed 15 years ago by mythtv@…

[mythtv] [PATCH] DBOX2 Feed Implementation 2005-08-02

Changed 15 years ago by mythtv@…

[mythtv] [PATCH] DBOX2 Feed Implementation 2005-08-02 (including missing files)

Changed 15 years ago by mythtv@…

[mythtv] [PATCH] DBOX2 Feed Implementation 2005-08-02 (including missing files)

comment:1 Changed 15 years ago by anonymous

Please use the second version of the patch (mythtv-dbox2-200508022011) as the first does not include new files.

comment:2 Changed 15 years ago by anonymous

Owner: changed from Isaac Richards to rtjacob@…

comment:3 Changed 15 years ago by taylor

Owner: changed from rtjacob@… to taylor

comment:4 Changed 15 years ago by anonymous

Resolution: fixed
Status: newclosed

comment:5 Changed 15 years ago by mythtv@…

Resolution: fixed
Severity: mediumhigh
Status: closedreopened

Somehow the new files did not get added. Please make sure the following files are added to svn asap, because otherwise myth won't compile anymore.

libs/libmythtv/dbox2channel.cpp libs/libmythtv/dbox2channel.h libs/libmythtv/dbox2epg.cpp libs/libmythtv/dbox2epg.h libs/libmythtv/dbox2recorder.cpp libs/libmythtv/dbox2recorder.h

Reopening this ticket until fixed.

Lev.

comment:6 Changed 15 years ago by Isaac Richards

Resolution: fixed
Status: reopenedclosed

comment:7 Changed 4 weeks ago by Ian Campbell <ijc@…>

In 1236aef0a/mythtv:

Fix musicmetadata handling of compilations.

Fixes #13585
Closes #192

Signed-off-by: David Hampton <mythtv@…>


Squashed commit of the following:

commit ca6ffb883c9f32ec8a7f1461a0b4d71914e3c210
Author: Ian Campbell <ijc@…>
Date: Mon Mar 16 20:18:29 2020 +0800

musicmetadata: check for empty field before dumping to db

This ensures all the fields are properly filled in. In particular it ensures
that non-compilation albums have the compilation artist filled in to match the
artist, otherwise they all end up with "Unknown Artist" which in turn means
that albums which happen to have the same title (e.g. "Greatest Hits") all get
lumped into one.

commit 88418b6c7c400d04440eeeaf232f571a1463b09a
Author: Ian Campbell <ijc@…>
Date: Mon Mar 16 20:02:28 2020 +0800

musicmetadata: clear id fields when main field is set

... otherwise they are never recalculated when the actual value changes.

commit a0e93004c18f3a34c2c2d450af72366860a19b4e
Author: Ian Campbell <ijc@…>
Date: Sun Mar 15 15:35:32 2020 +0800

musicmetadata: Fully update music_albums, including name and artist

Since these may have changed.

commit 30898722aebbcfbd9d28557fcdbf2324379db2b6
Author: Ian Campbell <ijc@…>
Date: Sun Mar 15 15:33:43 2020 +0800

musicmetadata: Do not call ensureSortFields after checkEmptyFields

The latter already calls the former right at the end.

commit 2e4a0e93768142c05bcfcd1b58f1b7db7bbde609
Author: Ian Campbell <ijc@…>
Date: Fri Feb 28 07:15:41 2020 +0800

musicmetadata: ensure compilation artist id is always set

I was observing that I had one music_albums entry per track on each
compilation album after the album was scanned the second time (first time it
went in correctly).

The issue was that on reloading from the DB the field was not being initialised
so remained as -1 when the entry came to be written back, which because the
field in the DB is unsigned ended up being stored as 0, so when subsequent
lookups try to find the album it failed every time (since the 0 in the database
matches neither -1 nor the >0 correct value) and a fresh one is inserted for
every track.

Fix this by adding and using {get,set}CompilationArtistId corresponding to
the uses of {get,set}ArtistId. I broke out getCompilationArtistId from the
within exiting getArtistId implementation.

commit 56506e477ceb815081ed05aea3ff6656413b592a
Author: Ian Campbell <ijc@…>
Date: Wed Feb 19 20:05:22 2020 +0800

metaioflacvorbis: Handle ALBUMARTIST as a fallback for COMPILATION_ARTIST

Although there is no real standard this is as described in
https://picard.musicbrainz.org/docs/mappings/ and what one gets by default
using the picard tool (as I do).

commit 1e303b005e4b613e4b965b1a5cbdc830b64020c2
Author: Ian Campbell <ijc@…>
Date: Thu Feb 27 20:00:05 2020 +0800

Support mythutil --scanmusic --force to ignore file timestamps

Useful after an upgrade (or while hacking) or if something else changed which
doesn't affect the timestamp of the file.

comment:8 Changed 4 weeks ago by Ian Campbell <ijc@…>

In 672d45b7b/mythtv:

Fix musicmetadata handling of compilations.

Fixes #13585
Closes #192

Signed-off-by: David Hampton <mythtv@…>

(cherry picked from commit 1236aef0ae520294446ed91d91ed0e988976e183)


Squashed commit of the following:

commit ca6ffb883c9f32ec8a7f1461a0b4d71914e3c210
Author: Ian Campbell <ijc@…>
Date: Mon Mar 16 20:18:29 2020 +0800

musicmetadata: check for empty field before dumping to db

This ensures all the fields are properly filled in. In particular it ensures
that non-compilation albums have the compilation artist filled in to match the
artist, otherwise they all end up with "Unknown Artist" which in turn means
that albums which happen to have the same title (e.g. "Greatest Hits") all get
lumped into one.

commit 88418b6c7c400d04440eeeaf232f571a1463b09a
Author: Ian Campbell <ijc@…>
Date: Mon Mar 16 20:02:28 2020 +0800

musicmetadata: clear id fields when main field is set

... otherwise they are never recalculated when the actual value changes.

commit a0e93004c18f3a34c2c2d450af72366860a19b4e
Author: Ian Campbell <ijc@…>
Date: Sun Mar 15 15:35:32 2020 +0800

musicmetadata: Fully update music_albums, including name and artist

Since these may have changed.

commit 30898722aebbcfbd9d28557fcdbf2324379db2b6
Author: Ian Campbell <ijc@…>
Date: Sun Mar 15 15:33:43 2020 +0800

musicmetadata: Do not call ensureSortFields after checkEmptyFields

The latter already calls the former right at the end.

commit 2e4a0e93768142c05bcfcd1b58f1b7db7bbde609
Author: Ian Campbell <ijc@…>
Date: Fri Feb 28 07:15:41 2020 +0800

musicmetadata: ensure compilation artist id is always set

I was observing that I had one music_albums entry per track on each
compilation album after the album was scanned the second time (first time it
went in correctly).

The issue was that on reloading from the DB the field was not being initialised
so remained as -1 when the entry came to be written back, which because the
field in the DB is unsigned ended up being stored as 0, so when subsequent
lookups try to find the album it failed every time (since the 0 in the database
matches neither -1 nor the >0 correct value) and a fresh one is inserted for
every track.

Fix this by adding and using {get,set}CompilationArtistId corresponding to
the uses of {get,set}ArtistId. I broke out getCompilationArtistId from the
within exiting getArtistId implementation.

commit 56506e477ceb815081ed05aea3ff6656413b592a
Author: Ian Campbell <ijc@…>
Date: Wed Feb 19 20:05:22 2020 +0800

metaioflacvorbis: Handle ALBUMARTIST as a fallback for COMPILATION_ARTIST

Although there is no real standard this is as described in
https://picard.musicbrainz.org/docs/mappings/ and what one gets by default
using the picard tool (as I do).

commit 1e303b005e4b613e4b965b1a5cbdc830b64020c2
Author: Ian Campbell <ijc@…>
Date: Thu Feb 27 20:00:05 2020 +0800

Support mythutil --scanmusic --force to ignore file timestamps

Useful after an upgrade (or while hacking) or if something else changed which
doesn't affect the timestamp of the file.

Note: See TracTickets for help on using tickets.